Skip to content

AutoML.fit(wait=False) requires explicit logs=False #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
athewsey opened this issue Jun 12, 2020 · 2 comments
Closed

AutoML.fit(wait=False) requires explicit logs=False #1584

athewsey opened this issue Jun 12, 2020 · 2 comments
Labels
status: pending release The fix have been merged but not yet released to PyPI type: feature request

Comments

@athewsey
Copy link
Collaborator

Describe the bug

Calling AutoML.fit(..., wait=False) will throw an error, requiring users to explicitly add the logs=False parameter.

The documentation does technically point out that logs defaults to True and that the parameter is "only meaningful when wait is True" - which implies inconsistent combinations would be ignored, rather than triggering error.

The behaviour is inconsistent with other functions e.g. Estimator.fit() where wait=False doesn't require a separate explicit logs configuration. Seems like it's accidental rather than a deliberate choice.

To reproduce

Create a sagemaker.automl.automl.AutoML instance and call .fit() with parameter wait=False and not specifying logs parameter.

Expected behavior

The job starts and the function returns without blocking the kernel. No logs printed because we're not waiting on the job: Comparable to Estimator.fit().

Screenshots or logs

Error as below:

ValueError: Logs can only be shown if wait is set to True.
                Please either set wait to True or set logs to False.

System information
A description of your system. Please provide:

  • SageMaker Python SDK version: 1.60.0
  • Framework name (eg. PyTorch) or algorithm (eg. KMeans): AutoML
  • Framework version: N/A
  • Python version: 3.7.6
  • CPU or GPU: CPU
  • Custom Docker image (Y/N): N (SM Studio Py3 Data Science kernel)

Additional context

Relevant part of the documentation:

  • wait (bool) – Whether the call should wait until the job completes (default: True).
  • logs (bool) – Whether to show the logs produced by the job. Only meaningful when wait is True (default: True).
@laurenyu
Copy link
Contributor

fixed in #1585. should be released tomorrow morning

@laurenyu laurenyu added the status: pending release The fix have been merged but not yet released to PyPI label Jun 17, 2020
@laurenyu
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending release The fix have been merged but not yet released to PyPI type: feature request
Projects
None yet
Development

No branches or pull requests

3 participants