Skip to content

fix: set logs to False if wait is False #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 17, 2020
Merged

fix: set logs to False if wait is False #1585

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6e5a794
fix: set logs to False if wait is False
Jun 12, 2020
7751e62
update unit test to test not raising error when wait is False logs is…
Jun 15, 2020
c066263
add warning
Jun 15, 2020
60464de
black check
Jun 15, 2020
30092da
Merge branch 'master' into auto-ml
chuyang-deng Jun 15, 2020
b8e8d61
test wait not called
chuyang-deng Jun 15, 2020
1de42cb
update warning message
chuyang-deng Jun 15, 2020
151e24c
fix pylint error
chuyang-deng Jun 16, 2020
1401351
remove trailing whitespace
chuyang-deng Jun 16, 2020
99e07f9
Merge branch 'master' into auto-ml
chuyang-deng Jun 16, 2020
43dea22
Merge branch 'master' into auto-ml
laurenyu Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/sagemaker/automl/automl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,16 +78,13 @@ def fit(self, inputs=None, wait=True, logs=True, job_name=None):
is stored. Or an AutoMLInput object. If a local path is provided, the dataset will
be uploaded to an S3 location.
wait (bool): Whether the call should wait until the job completes (default: True).
logs (bool): Whether to show the logs produced by the job.
Only meaningful when wait is True (default: True).
logs (bool): Whether to show the logs produced by the job. Only meaningful when wait
is True (default: True). if `wait` is False, `log` will be set to False as well.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: logs missing s
if wait is False, log**s** will be set to False as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! updated!

job_name (str): Training job name. If not specified, the estimator generates
a default job name, based on the training image name and current timestamp.
"""
if logs and not wait:
raise ValueError(
"""Logs can only be shown if wait is set to True.
Please either set wait to True or set logs to False."""
)
if not wait:
logs = False

# upload data for users if provided local path
# validations are done in _Job._format_inputs_to_input_config
Expand Down