chore: Fail build if code coverage is too low #325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Remove code coverage from base python command, add a dedicated code coverage environment, as well as code build specs to run it.
If we have all test environments running code coverage and configure it to fail on low coverage, we run into issues with things like integration tests, which intentionally are not exhaustive in their coverage. Plus running coverage on every test isn't that useful without a mechanism to do something about it (hoping a human happens to look at the output doesn't count).
So, make code coverage a dedicated target, have it target unit tests, and set a high threshold.
See also: aws/aws-dynamodb-encryption-python#153
Testing:
Building gives me:
If I bump the threshold to 99, the build fails with:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: