chore: Add dedicated code coverage tox environment #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farleyb-amazon
force-pushed
the
code-coverage
branch
from
513acba to
f2cb943
Compare
robin-aws
reviewed
Mar 26, 2021
| @@ -9,6 +9,7 @@ branch = True | |||
|
|
|||
| [coverage:report] | |||
| show_missing = True | |||
| fail_under = 70 | |||
There was a problem hiding this comment.
This, on the other hand [1], we definitely have to get higher. :)
[1] https://github.com/aws/aws-encryption-sdk-python/pull/325/files#r602435534
robin-aws
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Remove code coverage from default python commands, add a dedicated code coverage environment, as well as code build specs to run it.
See also aws/aws-encryption-sdk-python#325, aws/aws-dynamodb-encryption-python#153
Differences from the other PRs:
Testing:
Confirmed build fails if I try to set the coverage threshold higher.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.