chore: Fail build if code coverage is too low #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
farleyb-amazon
force-pushed
the
code-coverage
branch
from
6b8a90d to
4a1351b
Compare
robin-aws
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Remove code coverage from base python command, add a dedicated code coverage environment, as well as code build specs to run it.
See also: aws/aws-encryption-sdk-python#325
Threshold of 90% chosen because current coverage is 91%.
Testing:
Building gives me:
If I bump the threshold to 95, the build fails with:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.