Skip to content

feat: revert keyrings #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 8, 2020
Merged

feat: revert keyrings #271

merged 7 commits into from
Jun 8, 2020

Conversation

mattsb42-aws
Copy link
Member

@mattsb42-aws mattsb42-aws commented May 22, 2020

Description of changes:

Because of the delays that we introduced that are blocking the release of keyrings[1], this reverts the keyring changes to unblock releases between now and the keyring release. Keyring work is now present over on the keyring branch.

NOTE: This revert is messy in no small part because the keyring branch lived for so long without merging back into master. One of the affects of this is that we completely changed how a lot of our CI worked in that branch, and that carried over into master when we merged. This is why this "revert" PR retains the CI changes: both because the user experience of the new CI is much better and because our branch protection rules now require these 70+ checks and temporarily removing that requirement is non-trivial.

[1] https://github.com/awslabs/aws-encryption-sdk-specification/milestone/1

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@mattsb42-aws mattsb42-aws requested a review from seebees June 8, 2020 21:08
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattsb42-aws mattsb42-aws merged commit c961999 into aws:master Jun 8, 2020
@mattsb42-aws mattsb42-aws deleted the revert branch June 8, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants