feat: refactor raw RSA keyrings configuration per #257 #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/README.md
Outdated
| @@ -49,9 +49,9 @@ We start with AWS KMS examples, then show how to use other wrapping keys. | |||
| * [with keyrings](./src/keyring/raw_aes/raw_aes.py) | |||
| * [with master key providers](./src/master_key_provider/raw_aes/raw_aes.py) | |||
| * How to use a raw RSA wrapping key | |||
| * [with keyrings](./src/keyring/raw_rsa/private_key_only.py) | |||
| * [with keyrings](src/keyring/raw_rsa/keypair.py) | |||
There was a problem hiding this comment.
you have the './' on the other examples still, should those be updated too?
There was a problem hiding this comment.
Good catch. I think my IDE's auto-refactor did that.
WesleyRosenblum
approved these changes
Apr 23, 2020
seebees
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
resolves: #257
Description of changes:
Changes as determined in #257.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: