Skip to content

[keyring] change raw RSA keyring to fit spec clarification #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
mattsb42-aws opened this issue Apr 22, 2020 · 0 comments · Fixed by #260
Closed
3 tasks done

[keyring] change raw RSA keyring to fit spec clarification #257

mattsb42-aws opened this issue Apr 22, 2020 · 0 comments · Fixed by #260

Comments

@mattsb42-aws
Copy link
Member

mattsb42-aws commented Apr 22, 2020

Per awslabs/aws-encryption-sdk-specification#91, the following changes need to be made to the raw RSA keyring:

  • If only a private key is provided, the keyring MUST NOT derive a private key from it for use on encrypt.
  • If no public key is provided, the keyring MUST throw an exception on encrypt.
  • If a public key and private key that are not part of the same keypair are provided, the keyring MUST throw an error.
@mattsb42-aws mattsb42-aws added this to the keyrings milestone Apr 22, 2020
mattsb42-aws added a commit that referenced this issue Apr 23, 2020
* feat: refactor raw RSA keyrings configuration per #257

* fix: raw RSA keyring must raise an error on encrypt if public key is not available

* docs: fix links in examples readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants