Skip to content

chore(docs): mark docs/snippets package as private #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Mar 4, 2024

Description of your changes

This PR marks the docs/snippets package as private so that it's excluded by the publishing process. This change is needed because we recently included the package as part of the lerna workspace but doesn't constitute a change in which packages are actually published.

The PR also fixes the command that bumps the version in the UA.

Related issues, RFCs

Issue number: #2160

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Mar 4, 2024
@dreamorosi dreamorosi requested a review from a team March 4, 2024 14:46
@dreamorosi dreamorosi requested a review from a team as a code owner March 4, 2024 14:46
@dreamorosi dreamorosi linked an issue Mar 4, 2024 that may be closed by this pull request
2 tasks
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation dependencies Changes that touch dependencies, e.g. Dependabot, etc. labels Mar 4, 2024
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Mar 4, 2024
am29d
am29d previously approved these changes Mar 4, 2024
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Mar 4, 2024
@dreamorosi dreamorosi linked an issue Mar 4, 2024 that may be closed by this pull request
2 tasks
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dreamorosi dreamorosi merged commit c3800e3 into main Mar 4, 2024
@dreamorosi dreamorosi deleted the 2160-maintenance-make-docssnippets-package-private branch March 4, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: make docs/snippets package private Maintenance: fix PT_VERSION in make-release workflow
2 participants