Skip to content

Maintenance: fix PT_VERSION in make-release workflow #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
am29d opened this issue Mar 4, 2024 · 2 comments · Fixed by #2156 or #2161
Closed
1 of 2 tasks

Maintenance: fix PT_VERSION in make-release workflow #2158

am29d opened this issue Mar 4, 2024 · 2 comments · Fixed by #2156 or #2161
Assignees
@am29d
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@am29d
Copy link
Contributor

am29d commented Mar 4, 2024 •
edited
Loading

Summary

The PT_VERSION variable in version.ts is renamed during the make-version workflow to VERSION instead of PT_VERSION. We don't run checks before commit, and we don't use commit hooks for this workflow, which therefore can't catch the issue.

Why is this needed?

So we can keep the correct working of SDK agent.

Which area does this relate to?

No response

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.
@am29d am29d added triage This item has not been triaged by a maintainer, please wait internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Mar 4, 2024
@am29d am29d added automation This item relates to automation and removed triage This item has not been triaged by a maintainer, please wait labels Mar 4, 2024
@dreamorosi dreamorosi linked a pull request Mar 4, 2024 that will close this issue
chore(ci): bump version to 2.0.0 #2156
Merged
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Mar 4, 2024
@dreamorosi dreamorosi added the completed This item is complete and has been merged/shipped label Mar 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi reopened this Mar 4, 2024
@github-project-automation github-project-automation bot moved this from Shipped to Pending review in Powertools for AWS Lambda (TypeScript) Mar 4, 2024
@dreamorosi dreamorosi linked a pull request Mar 4, 2024 that will close this issue
chore(docs): mark docs/snippets package as private #2161
Merged
9 tasks
@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in Powertools for AWS Lambda (TypeScript) Mar 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@am29d am29d

Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
Powertools for AWS Lambda (TypeScript)
Status: Shipped
Milestone
No milestone
2 participants
@am29d @dreamorosi