Skip to content

Maintenance: make docs/snippets package private #2160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Mar 4, 2024 · 2 comments · Fixed by #2161
Closed
1 of 2 tasks

Maintenance: make docs/snippets package private #2160

dreamorosi opened this issue Mar 4, 2024 · 2 comments · Fixed by #2161
Assignees
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Summary

The docs/snippets workspace has been added to Lerna so that it's included during version bumps, however we have forgotten to add the "private": true, directive to the docs/snippets/package.json file so that it's excluded from publishing.

This causes the release workflow to fail.

Why is this needed?

So that the release workflow can follow through.

Which area does this relate to?

Automation

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added triage This item has not been triaged by a maintainer, please wait internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Mar 4, 2024
@dreamorosi dreamorosi linked a pull request Mar 4, 2024 that will close this issue
9 tasks
Copy link
Contributor

github-actions bot commented Mar 4, 2024

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

This is now released under v2.0.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Mar 4, 2024
@dreamorosi dreamorosi removed the triage This item has not been triaged by a maintainer, please wait label Mar 4, 2024
@dreamorosi dreamorosi self-assigned this Mar 4, 2024
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
Development

Successfully merging a pull request may close this issue.

1 participant