Skip to content

tests(parameters): added missing tests for DynamoDBProvider #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Feb 10, 2023

Description of your changes

#1244 introduced integration tests for DynamoDBProvider, a provider part of the upcoming Parameters utility. At the time, the feature that allowed to inject a custom AWS SDK client was not present. The feature was added in #1222.

This PR adds some missing test cases to the integration tests of the provider to cover both the new feature, as well as testing cache and forceFetch behaviors.

How to verify this change

See checks under the PR as well as integration tests.

Note that the integration tests for the Parameters utility are not yet connected to the workflow, so here's a screenshot of a successful run from my local environment:
image

Related issues, RFCs

Issue number: #1272

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Feb 10, 2023
@dreamorosi dreamorosi linked an issue Feb 10, 2023 that may be closed by this pull request
2 tasks
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Feb 10, 2023
@dreamorosi dreamorosi added parameters This item relates to the Parameters Utility tests PRs that add or change tests labels Feb 10, 2023
@dreamorosi dreamorosi merged commit db215dd into main Feb 10, 2023
@dreamorosi dreamorosi deleted the 1272-maintenance-add-missing-tests-to-dynamodbprovider branch February 10, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parameters This item relates to the Parameters Utility size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: add missing tests to DynamoDBProvider
1 participant