Skip to content

Maintenance: add missing tests to DynamoDBProvider #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
dreamorosi opened this issue Feb 6, 2023 · 1 comment · Fixed by #1285
Closed
1 of 2 tasks

Maintenance: add missing tests to DynamoDBProvider #1272

dreamorosi opened this issue Feb 6, 2023 · 1 comment · Fixed by #1285
Assignees
@dreamorosi
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parameters This item relates to the Parameters Utility
Milestone
Parameters - Beta...

Comments

@dreamorosi
Copy link
Contributor

Summary

Now that #1222 has been merged and that DynamoDBProvider accepts a custom AWS SDK client, we need to update the integration (e2e) tests already implemented to include this feature.

The tests were introduced in #1244 where tests number 7 & 8 were already defined, but were blocked due to the missing feature added in #1222.

This issue captures the work package needed to introduce these two aforementioned tests.

Why is this needed?

To improve the test coverage of the provider/utility.

Which area does this relate to?

Tests, Parameters

Solution

No response

Acknowledgment
@dreamorosi dreamorosi added triage This item has not been triaged by a maintainer, please wait internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parameters This item relates to the Parameters Utility labels Feb 6, 2023
@dreamorosi dreamorosi added this to the Parameters - Beta release milestone Feb 6, 2023
@dreamorosi dreamorosi changed the title Maintenance: add Maintenance: add missing tests to DynamoDBProvider Feb 6, 2023
@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation and removed triage This item has not been triaged by a maintainer, please wait labels Feb 7, 2023
@dreamorosi dreamorosi self-assigned this Feb 10, 2023
@dreamorosi dreamorosi moved this from Backlog to Working on it in AWS Lambda Powertools for TypeScript Feb 10, 2023
@dreamorosi dreamorosi mentioned this issue Feb 10, 2023
Merged
13 tasks
@dreamorosi dreamorosi linked a pull request Feb 10, 2023 that will close this issue
tests(parameters): added missing tests for DynamoDBProvider #1285
Merged
13 tasks
@dreamorosi dreamorosi moved this from Working on it to Pending review in AWS Lambda Powertools for TypeScript Feb 10, 2023
@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in AWS Lambda Powertools for TypeScript Feb 10, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed confirmed The scope is clear, ready for implementation labels Feb 10, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in AWS Lambda Powertools for TypeScript Feb 10, 2023
@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label Feb 10, 2023
@dreamorosi dreamorosi removed the pending-release This item has been merged and will be released soon label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parameters This item relates to the Parameters Utility
Projects
None yet
Milestone
Parameters - Beta release
1 participant
@dreamorosi