-
Notifications
You must be signed in to change notification settings - Fork 153
Feature request: support providing aws sdk v3 client #1222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey, @dreamorosi! Let's implement this. The plan is to use a client that was passed to the provider constructor in If there aren't any other things to consider, I can start working on the PR. |
Hey Sergei, sure let's do it. I actually initially didn't think of making any checks, but it's a good point. Let's do a simple check on whether the client passed is an instance of the class that we expect, and if not, we throw an error like you suggested. We should also modify the interface/type of the constructor options object to make either Other than that, at the moment I can't think of anything else! Happy for you to work on this :) |
|
Use case
The upcoming Parameters utility should allow customers to pass their own AWS SDK v3 client to a given provider.
This is useful for those cases in which a client is already available, for tracing the requests made by the client, or for testing (injection).
The feature is supported by the Python's version and already present in the documentation, however the implementation was left out initially.
Solution/User Experience
Alternative solutions
Acknowledgment
The text was updated successfully, but these errors were encountered: