Skip to content

chore(all): removed unused npm scripts + moved linting in PR checks #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 8, 2022

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Oct 18, 2022

Description of your changes

This PR supersedes #1107 by replicating most of the changes introduced in that PR as well as removing all lerna related commands (except lerna version & lerna publish in the Make Release workflow) in favor of npm workspace-based ones.

Just like #1107, this PR:

  • Changes the husky scripts to:
    • Run npm run lint-fix -ws on pre-commit
    • Run npm t -ws on pre-push which runs unit tests on all utilities & not on examples & layer publisher (read on)
  • Updates the workflow that is run on PR updates to check linting, if non-formatted code is pushed to a PR the automated checks will fail
  • Removed all extra lint, lint-fix, etc. around versioning. The changes from the point above should prevent non-formatted code to be merged in the first place.
  • Removes all lerna-* commands from the main package.json file & update the only two instances in which they were referenced in the CONTRIBUTING doc.
  • Adds .eslintrc.js and tsconfig.es.json files, as well as the --resolve-plugins-relative-to . flag to npm run lint so to examples/* and layer-publisher to allow for local linting. This is needed because they're not part of the npm workspace so they expect their own configs and not the ones from the monorepo while in CI/CD.
  • Update GH CodeSpaces & GitPod devfiles so that the changes above are reflected.

Fixes #1106

How to verify this change

See automated checks

Related issues, RFCs

Issue number: #1106

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Oct 18, 2022
@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Oct 18, 2022
@dreamorosi dreamorosi marked this pull request as draft October 18, 2022 17:39
@dreamorosi dreamorosi marked this pull request as ready for review October 19, 2022 09:57
@dreamorosi dreamorosi mentioned this pull request Nov 3, 2022
13 tasks
Copy link
Contributor

@ijemmy ijemmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for cleaning this up.

Just one question and a change on CONTRIBUTING.md

Copy link
Contributor

@flochaz flochaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work !

@dreamorosi dreamorosi merged commit 56a7b47 into main Nov 8, 2022
@dreamorosi dreamorosi deleted the chore/clean_up_linting_versioning branch November 8, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: run tests on examples only in CI and not on pre-push locally
3 participants