-
Notifications
You must be signed in to change notification settings - Fork 153
chore(all): removed unused npm scripts + moved linting in PR checks #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
ijemmy
suggested changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for cleaning this up.
Just one question and a change on CONTRIBUTING.md
…s/aws-lambda-powertools-typescript into chore/clean_up_linting_versioning
flochaz
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work !
ijemmy
approved these changes
Nov 8, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
internal
PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR supersedes #1107 by replicating most of the changes introduced in that PR as well as removing all
lerna
related commands (exceptlerna version
&lerna publish
in the Make Release workflow) in favor of npm workspace-based ones.Just like #1107, this PR:
husky
scripts to:npm run lint-fix -ws
onpre-commit
npm t -ws
onpre-push
which runs unit tests on all utilities & not on examples & layer publisher (read on)lint
,lint-fix
, etc. around versioning. The changes from the point above should prevent non-formatted code to be merged in the first place.lerna-*
commands from the mainpackage.json
file & update the only two instances in which they were referenced in the CONTRIBUTING doc..eslintrc.js
andtsconfig.es.json
files, as well as the--resolve-plugins-relative-to .
flag tonpm run lint
so toexamples/*
andlayer-publisher
to allow for local linting. This is needed because they're not part of the npm workspace so they expect their own configs and not the ones from the monorepo while in CI/CD.Fixes #1106
How to verify this change
See automated checks
Related issues, RFCs
Issue number: #1106
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.