Maintenance: run tests on examples only in CI and not on pre-push locally #1106
Labels
automation
This item relates to automation
completed
This item is complete and has been merged/shipped
internal
PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
tests
PRs that add or change tests
Description of the feature request
Problem statement
At the moment we are running unit tests for all examples every time we are pushing code as a part of the
pre-push
hooks. This is a relic of a time (a year ago) during which we were using the monorepo/linked version of the utilities in the examples.Since a long time we have moved the examples to use the published version. This means that even when one of the utilities changes, testing the examples is redundant as they won't be using the changed version.
This issue proposes to remove the unit test run for examples from the
pre-push
commit. Examples will be tested only as a part of the CI checks in a PR and potentially only when there are changes in the files underexamples/*
.Summary of the feature
Remove the examples from the
pre-commit
,pre-push
hooks.Code examples
N/A
Benefits for you and the wider AWS community
With this change the DX for maintainers will improve as it removes the need of using
--no-verify
when wanting a faster feedback look.Describe alternatives you've considered
N/A
Additional context
N/A
Related issues, RFCs
N/A
The text was updated successfully, but these errors were encountered: