Skip to content

Maintenance: run tests on examples only in CI and not on pre-push locally #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dreamorosi opened this issue Sep 29, 2022 · 1 comment · Fixed by #1125
Closed

Maintenance: run tests on examples only in CI and not on pre-push locally #1106

dreamorosi opened this issue Sep 29, 2022 · 1 comment · Fixed by #1125
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tests PRs that add or change tests

Comments

@dreamorosi
Copy link
Contributor

Description of the feature request

Problem statement

At the moment we are running unit tests for all examples every time we are pushing code as a part of the pre-push hooks. This is a relic of a time (a year ago) during which we were using the monorepo/linked version of the utilities in the examples.

Since a long time we have moved the examples to use the published version. This means that even when one of the utilities changes, testing the examples is redundant as they won't be using the changed version.

This issue proposes to remove the unit test run for examples from the pre-push commit. Examples will be tested only as a part of the CI checks in a PR and potentially only when there are changes in the files under examples/*.

Summary of the feature
Remove the examples from the pre-commit, pre-push hooks.

Code examples
N/A

Benefits for you and the wider AWS community
With this change the DX for maintainers will improve as it removes the need of using --no-verify when wanting a faster feedback look.

Describe alternatives you've considered
N/A

Additional context
N/A

Related issues, RFCs

N/A

@dreamorosi dreamorosi added triage This item has not been triaged by a maintainer, please wait internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Sep 29, 2022
@dreamorosi dreamorosi self-assigned this Oct 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi added automation This item relates to automation tests PRs that add or change tests and removed triage This item has not been triaged by a maintainer, please wait labels Nov 9, 2022
@dreamorosi dreamorosi added the completed This item is complete and has been merged/shipped label Nov 14, 2022
@dreamorosi dreamorosi changed the title Feature (examples): run tests on examples only in CI and not on pre-push locally Maintenance: run tests on examples only in CI and not on pre-push locally Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tests PRs that add or change tests
Projects
None yet
1 participant