fix: version command refactor #1107
Conversation
| @@ -1,5 +1,4 @@ | |||
| #!/bin/sh | |||
| . "$(dirname "$0")/_/husky.sh" | |||
|
|
|||
| npm run lerna-lint-fix | |||
| npm run test | |||
There was a problem hiding this comment.
I think we should change this to npm test -ws.
Currently, it will run npm run lerna-test which will run tests in all packages, examples, and layer-publisher.
If instead we changed it to the above we'd be running the unit tests only in packages/* and not in the others.
This is on line with what we discussed in the last conversation about the topic and is captured in #1106. If you want to keep this separate I can open a PR later on.
Aside from where the tests are run only difference between npm run test & npm test -ws is that npm workspaces still doesn't run in parallel but sequentially. I don't think it's a big deal at this stage, but if you want to run it in parallel you can use npm t -w packages/commons & npm t -w packages/logger & npm t -w packages/tracer & npm t -w packages/metrics instead.
Co-authored-by: Florian Chazal <[email protected]>
Co-authored-by: Florian Chazal <[email protected]>
… version (1.2.1) (#1113) * chore(build): don't rely on shell shortcut * doc: bump layer to version 2 corresponding to 1.2.1 PowerTools version Co-authored-by: Florian Chazal <[email protected]>
…methods (#1108) * chore: added unit test for captureMethod async/await * chore: added unit test for captureLambdaHandler async/await * chore: added comments to document unit test cases * Update packages/tracer/tests/unit/Tracer.test.ts Co-authored-by: ijemmy <[email protected]> * Update packages/tracer/tests/unit/Tracer.test.ts Co-authored-by: ijemmy <[email protected]> * chore: fix linting Co-authored-by: ijemmy <[email protected]>
) * feat: specify subsegment name when capturing class method * chore: update key for e2e test cases * chore: add tips to the docs about setting custom name * Update docs/core/tracer.md Co-authored-by: Josh Kellendonk <[email protected]> * Update packages/tracer/src/types/Tracer.ts * fix merge conflicts Co-authored-by: Josh Kellendonk <[email protected]>
…asset (#1116) Co-authored-by: Florian Chazal <[email protected]>
* fix: update version command to use lint-fix * fix: update version command to use lint-fix
|
Closing in favor of #1125 |
Description of your changes
This PR removes all linting related commands from the NPM versioning hooks and makes sure it's done in the CI/CD pipelines actions.
How to verify this change
Related issues, RFCs
Issue number:
PR status
Is this ready for review?: NO
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.