feat: add tracer #107
Merged
feat: add tracer #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saragerion
requested review from
saragerion,
gsingh1,
loujaybee and
alan-churley
|
Reminder: review this first draft @alan-churley @saragerion |
|
Coverage after merging feature/tracer into main
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Coverage after merging feature/tracer into main
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Coverage after merging feature/tracer into main
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
dreamorosi
commented
Jul 29, 2021
flochaz
suggested changes
Dec 8, 2021
flochaz
previously approved these changes
Dec 10, 2021
saragerion
previously approved these changes
Dec 10, 2021
Comment on lines
5
to
9
| // Reserved environment variables | ||
| private awsExecutionEnv = 'AWS_EXECUTION_ENV'; | ||
| private chaliceLocalVariable = 'AWS_CHALICE_CLI_MODE'; | ||
| private samLocalVariable = 'AWS_SAM_LOCAL'; | ||
| private xRayTraceIdVariable = '_X_AMZN_TRACE_ID'; |
There was a problem hiding this comment.
Minor: only AWS_EXECUTION_ENV and _X_AMZN_TRACE_ID are reserved env variables, see here:
https://docs.aws.amazon.com/lambda/latest/dg/configuration-envvars.html#configuration-envvars-runtime
Also, chalice is a python library.
Suggested change
| // Reserved environment variables | |
| private awsExecutionEnv = 'AWS_EXECUTION_ENV'; | |
| private chaliceLocalVariable = 'AWS_CHALICE_CLI_MODE'; | |
| private samLocalVariable = 'AWS_SAM_LOCAL'; | |
| private xRayTraceIdVariable = '_X_AMZN_TRACE_ID'; | |
| // Reserved environment variables | |
| private awsExecutionEnv = 'AWS_EXECUTION_ENV'; | |
| private xRayTraceIdVariable = '_X_AMZN_TRACE_ID'; | |
| // Additional environment variables | |
| private samLocalVariable = 'AWS_SAM_LOCAL'; |
There was a problem hiding this comment.
Thank you, I like the proposed suggestion but I'll have to simply comment this section with // Environment variables because the suggested ordering conflicts with the eslint@typescript-eslint/member-ordering directive (samLocalVariable should be declared before xRayTraceIdVariable).
packages/tracing/tests/unit/config/EnvironmentVariablesService.test.ts
Outdated
Show resolved
Hide resolved
This was referenced Dec 10, 2021
This was
linked to
issues
Dec 10, 2021
saragerion
approved these changes
Dec 14, 2021
flochaz
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
First draft of the Tracer module, would really appreciate some feedback especially (but not limited to) the unit tests.
How to verify this change
Related issues, RFCs
N/A
PR status
Is this ready for review?: NO
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.