Skip to content

Feature request: define more specific types for decorators #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dreamorosi opened this issue Dec 13, 2021 · 5 comments
Closed

Feature request: define more specific types for decorators #302

dreamorosi opened this issue Dec 13, 2021 · 5 comments
Labels
confirmed The scope is clear, ready for implementation feature-request This item refers to a feature request for an existing or new utility tracer This item relates to the Tracer Utility
Milestone

Comments

@dreamorosi
Copy link
Contributor

Description of the feature request

As discussed internally, we need to define more specific types for the method decorator that currently uses the any type:

// TODO: Revisit type below & make it more specific
// eslint-disable-next-line  @typescript-eslint/no-explicit-any
type MethodDecorator = (target: any, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<any>) => any;

Related issues, RFCs

#107

@dreamorosi dreamorosi added help-wanted We would really appreciate some support from community for this one tracer This item relates to the Tracer Utility labels Dec 13, 2021
@dreamorosi dreamorosi added this to the production-ready-release milestone Dec 13, 2021
@dreamorosi dreamorosi added the good-first-issue Something that is suitable for those who want to start contributing label Feb 21, 2022
@saragerion saragerion self-assigned this May 24, 2022
@saragerion saragerion removed this from the production-ready-release milestone May 24, 2022
@dreamorosi
Copy link
Contributor Author

This issue requires further investigation and depending on the outcome, the current type might end up staying.

The new potential type should be able to accept any sync or async function. If this is not possible, we should document the reasoning here and remove the #TODO from the code.

If anyone is interested in picking this up, please leave a comment here, then discuss your findings and proposed changes before opening a PR.

@dreamorosi dreamorosi added feature-request This item refers to a feature request for an existing or new utility confirmed The scope is clear, ready for implementation labels Nov 13, 2022
@dreamorosi dreamorosi changed the title (tracer): define more specific types for decorators Feature request: define more specific types for decorators Nov 14, 2022
@dVp007
Copy link

dVp007 commented Apr 11, 2023

I would like to contribute and open a PR.

@dreamorosi
Copy link
Contributor Author

Hi @dVp007 thank you for offering to help on this issue.

Before starting to work on a PR, could you please write a short proposal of the implementation/changes in this issue so that we can discuss it and agree on the changes?

Once we are aligned on the plan, you can open a PR.

@dreamorosi
Copy link
Contributor Author

Closing this in favor of #1204

@dreamorosi dreamorosi closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Coming soon in Powertools for AWS Lambda (TypeScript) Sep 26, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi removed good-first-issue Something that is suitable for those who want to start contributing help-wanted We would really appreciate some support from community for this one labels Sep 26, 2023
@dreamorosi dreamorosi moved this from Coming soon to Closed in Powertools for AWS Lambda (TypeScript) Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed The scope is clear, ready for implementation feature-request This item refers to a feature request for an existing or new utility tracer This item relates to the Tracer Utility
Projects
Development

No branches or pull requests

3 participants