Skip to content

Feature request: logger review PowertoolLogFormatter.formatError() message field #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dreamorosi opened this issue Dec 14, 2021 · 1 comment
Closed

Feature request: logger review PowertoolLogFormatter.formatError() message field #304

dreamorosi opened this issue Dec 14, 2021 · 1 comment
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility good-first-issue Something that is suitable for those who want to start contributing logger This item relates to the Logger Utility
Milestone
production-ready-...

Comments

@dreamorosi
Copy link
Contributor

dreamorosi commented Dec 14, 2021 •
edited
Loading

Description of the feature request

Problem statement

We have observed a potential issue related to how node generates error messages that might affect the PowertoolLogFormatter.formatError() and that made unit tests fail.

An hot fix has been applied (here) but we need to make sure that all errors are formatted properly and that there are sufficient unit test cases.
@dreamorosi dreamorosi added the logger This item relates to the Logger Utility label Dec 14, 2021
@dreamorosi dreamorosi added this to the production-ready-release milestone Dec 14, 2021
dreamorosi added a commit that referenced this issue Dec 14, 2021
@dreamorosi
Applied fix to PowertoolLogFormatter see #304
8a5bcc0
dreamorosi added a commit that referenced this issue Dec 14, 2021
@dreamorosi
feat: add tracer (#107)
f92279f 
* WIP - Tracer basic implementation

* Reorder Tracer methods

* Added stub methods for captureAWS & Clients

* Removed lodash

* Fixed SAM & Chalice variable comparison

* Added tracing provider

* Added capture lambda decorator

* Unit tests + format

* Removed package-lock, added npm-shrinkwrap

* WIP: capture clients

* Updated license in package

* Simplified unit tests

* Added more tests

* WIP examples

* WIP method decorator

* Enable tracing only when running in Lambda

* Removed redundant env restore commands in tests

* Fixed ERR_UNHANDLED_REJECTION

* Removed debug logs

* Updated packages & config

* Documentation

* Typing & Tests

* Updated package & config

* Added capture method

* Changed TracerInterface

* Removed Chalice references

* Sorted imports

* Fixed type for return of captureLambdaHandler

* Linting tests

* Fixed linting & added TODOs

* Applied fix to PowertoolLogFormatter see #304
@dreamorosi dreamorosi added the good-first-issue Something that is suitable for those who want to start contributing label Feb 21, 2022
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi added feature-request This item refers to a feature request for an existing or new utility completed This item is complete and has been merged/shipped labels Nov 14, 2022
@dreamorosi dreamorosi changed the title (logger): review PowertoolLogFormatter.formatError() message field Feature request: logger review PowertoolLogFormatter.formatError() message field Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility good-first-issue Something that is suitable for those who want to start contributing logger This item relates to the Logger Utility
Projects
None yet
Milestone
production-ready-release
Development

No branches or pull requests
2 participants
@dreamorosi @saragerion