Improved the IDE startup and new sketch creation time #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The feature seems to work well now when auto-save is disabled. When we close a window (Sketch) or quit the IDE we should get two different messages.
This message should change based on the event. Quit IDE: |
kittaakos
commented
Jun 1, 2022
arduino-ide-extension/src/browser/arduino-frontend-contribution.tsx
Outdated
Show resolved
Hide resolved
| @@ -288,8 +290,6 @@ MonacoThemingService.register({ | |||
| }); | |||
|
|
|||
| export default new ContainerModule((bind, unbind, isBound, rebind) => { | |||
| ElementQueries.listen(); | |||
| ElementQueries.init(); | |||
There was a problem hiding this comment.
Include in the changelog?
There was a problem hiding this comment.
🤔 not sure, why do you think is useful? I might be missing something
3 tasks
fstasi
reviewed
Jun 6, 2022
fstasi
reviewed
Jun 6, 2022
fstasi
reviewed
Jun 6, 2022
kittaakos
force-pushed
the
startup-time-signed
branch
4 times, most recently
from
4e655e5 to
5b60cb4
Compare
Signed-off-by: Akos Kitta <[email protected]>
kittaakos
force-pushed
the
startup-time-signed
branch
from
5b60cb4 to
a78e7e8
Compare
fstasi
approved these changes
Jun 7, 2022
per1234
added
type: enhancement
3 tasks
per1234
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Change description
Other information
Reviewer checklist