Skip to content

GUI-based settings commands produce an empty interface #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
per1234 opened this issue Jun 9, 2022 · 2 comments · Fixed by #1046
Closed
3 tasks done

GUI-based settings commands produce an empty interface #1031

per1234 opened this issue Jun 9, 2022 · 2 comments · Fixed by #1046
Assignees
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Jun 9, 2022

Describe the problem

In addition to the common settings that are configurable via the Arduino IDE's File > Preferences dialog, there are some additional settings that can be useful to advanced users, beta testers, or for troubleshooting problems with the Arduino IDE.

These can be adjusted by manually editing a settings.json file. Previously, it was also possible to do via a graphical interface, accessed via a command palette command.

🐛 The advanced settings graphical interface is now empty, containing only the message "That search query has returned no results.".

To reproduce

  1. Open the "Command Palette".
    (Ctrl+Shift+P or Command+Shift+P by default)
  2. Run the "Preferences: Open Settings (UI)" command.

🐛 There are no settings, so the interface is pointless.

image

Expected behavior

Remove pointless and confusing command palette items.

- OR -

Restore the graphical advanced settings interface.

Arduino IDE version

2.0.0-rc7

Operating system

Windows

Operating system version

10

Additional context

Since the advanced settings will only be of interest to advanced users or users reporting problems with the IDE, who can be guided in their use by a knowledgeable helper, requiring manual editing of a JSON file to set them is perfectly reasonable, and in fact matches the approach used for the Arduino IDE 1.x advanced settings, which could only be configured by manually editing the preferences.txt file.

However, if this is to be done, the location, editing procedure, and method for obtaining the available key names and their descriptions must be documented.


I bisected the change to 4c55807

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jun 9, 2022
@serpinio
Copy link

serpinio commented Jun 10, 2022

Wait a minute...

From the 2.0.0-rc7 changelog popup that just showed up in my 2.0.0-RC6:

Breaking
Remove GUI-based advanced settings interface (e.g., "Preferences: Open Settings (UI)" command). (#1018) Advanced settings will now be configured by editing the settings.json file directly ("Open Settings (JSON)" or "Open Workspace Settings (JSON)" commands),

What was so horribly wrong with Open Settings (UI)? It was a very convenient place to fine-tune editor behavior, and who suddenly decided that "advanced settings will only be of interest to advanced users or users reporting problems with the IDE". Personally, while browsing the GUI I discovered and ended up changing 38 various settings thanks to descriptions available right there, next to the setting name, which in turn improved my productivity with the editor.

Why remove this option altogether? Am I missing some big idea?
Please, restore Open Settings (UI), no really, why remove something that worked just fine in 2.0.0-RC6?

@serpinio
Copy link

Thank you!!! You guys are awesome!

kittaakos pushed a commit that referenced this issue Jun 13, 2022
@per1234 per1234 added the conclusion: resolved Issue was resolved label Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants