Skip to content

[NO_MERGE][WIP] Startup time #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 45 commits into from
Closed

[NO_MERGE][WIP] Startup time #1004

wants to merge 45 commits into from

Conversation

kittaakos
Copy link
Contributor

Motivation

Change description

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added the status: on hold Do not proceed at this time label May 24, 2022
@kittaakos
Copy link
Contributor Author

@ubidefeo, if you have time, please check the IDE2. We have a mysterious app signing issue, so this PR is from a fork. Hence the IDE2 is not signed. You have to manually remove it from the quarantine or use System Preferences > Security & Privacy > General to allow the app to run.

Akos Kitta added 27 commits May 25, 2022 10:25
Dropped Git and the custom layout restorer.
db26148 
Signed-off-by: Akos Kitta <[email protected]>
duration decorator.
5da4b1a 
Signed-off-by: Akos Kitta <[email protected]>
get ws root withot check.
986d597 
Signed-off-by: Akos Kitta <[email protected]>
Enabled noImplicitOverride TS option.
8c95086 
Signed-off-by: Akos Kitta <[email protected]>
Switched to sketchRef for examples and builtins.
307546c 
Signed-off-by: Akos Kitta <[email protected]>
can disable splash.
77d7416 
Signed-off-by: Akos Kitta <[email protected]>
speed up examples load.
99caaa8 
Signed-off-by: Akos Kitta <[email protected]>
disabled old way of computing the examples.
9301121 
Signed-off-by: Akos Kitta <[email protected]>
do not resolve all sketches as possible ws roots.
23a1693 
Signed-off-by: Akos Kitta <[email protected]>
Generate bultin examples structure at build time.
ba1ff1a 
Signed-off-by: Akos Kitta <[email protected]>
load the list widget content only when activated.
5cecaab 
Signed-off-by: Akos Kitta <[email protected]>
reimpl. discovering sketches from the sketchbook
6179300 
Signed-off-by: Akos Kitta <[email protected]>
dropped old way of calculating sketchbook content
17b5646 
Signed-off-by: Akos Kitta <[email protected]>
fixed typo in logs.
7e5be19 
Signed-off-by: Akos Kitta <[email protected]>
changed how to init cli config service.
cf17ce1 
on daemon start, the port is broadcasted from BE.

Signed-off-by: Akos Kitta <[email protected]>
run update after show.
61279fe 
Signed-off-by: Akos Kitta <[email protected]>
fall back to new temp sketch URI when no recent WS
3e583a7 
Signed-off-by: Akos Kitta <[email protected]>
customized JSON schema store, editor navigation history, and preferen…
d5fabc1 
…ce tree generator.

Signed-off-by: Akos Kitta <[email protected]>
launch config to start with dev tools + w/o splash
fdca524 
Signed-off-by: Akos Kitta <[email protected]>
defer all menu updates before app is ready.
dbf635a 
Signed-off-by: Akos Kitta <[email protected]>
do not parse the CLI log JSON, use as is.
7ccb92b 
Signed-off-by: Akos Kitta <[email protected]>
fixed port for the LS.
67a456d 
Signed-off-by: Akos Kitta <[email protected]>
deferred contributions to start on app ready.
dc3b748 
Signed-off-by: Akos Kitta <[email protected]>
disabled "trick" for deferring menu update.
ab163a5 
Signed-off-by: Akos Kitta <[email protected]>
updated translation files.
469159e 
Signed-off-by: Akos Kitta <[email protected]>
i18n fixup.
08f6b27 
Signed-off-by: Akos Kitta <[email protected]>
removed native grpc dependencies.
c81d1c5 
bumped the grpc-js version.

Signed-off-by: Akos Kitta <[email protected]>
Akos Kitta added 5 commits May 25, 2022 13:24
Can start the IDE with content tracing.
71bbeda 
Signed-off-by: Akos Kitta <[email protected]>
Skip loading extensions for the Theia about dialog
ad76045 
It's unused in IDE2.

Signed-off-by: Akos Kitta <[email protected]>
Defer running the FW updates.
47620ef 
Signed-off-by: Akos Kitta <[email protected]>
Do not require the current window on IDE2 start.
bc3aee6 
It's expensive and sync.

Signed-off-by: Akos Kitta <[email protected]>
Do not explicitly initialize the layout on start.
313c96c 
It should be handled by the layout restorer.

Signed-off-by: Akos Kitta <[email protected]>
@ubidefeo ubidefeo marked this pull request as ready for review May 26, 2022 04:58
Akos Kitta added 9 commits May 27, 2022 09:11
Added missing protobuf dep.
68afacf 
Signed-off-by: Akos Kitta <[email protected]>
asynchronous core and lib index update.
c7f2f4f 
Signed-off-by: Akos Kitta <[email protected]>
💄 improved dev comments.
e27b9f1 
Signed-off-by: Akos Kitta <[email protected]>
removed debug log.
79503ef 
Signed-off-by: Akos Kitta <[email protected]>
run core and lib index updates parallel.
8ffee32 
Signed-off-by: Akos Kitta <[email protected]>
Use nightly (20220527) CLI and 2.2.0 FW uploader.
efe7399 
Signed-off-by: Akos Kitta <[email protected]>
Defer loading boards until the app is ready.
05af641 
Signed-off-by: Akos Kitta <[email protected]>
Open devtools when tracing.
b947be0 
Signed-off-by: Akos Kitta <[email protected]>
Resolve and cache current sketch.
2fbf3cb 
Signed-off-by: Akos Kitta <[email protected]>
per1234
per1234 requested changes May 31, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 The "Menu Bar" is missing from the IDE window:

image

To reproduce

  1. Start the Arduino IDE.

🐛 The "Menu Bar" is missing.

Expected behavior

Standard menu bar:

image

Arduino IDE version

2.0.0-rc6-snapshot-56ac219
(Tester build for 2fbf3cb)

Operating system

Windows 10, Ubuntu 20.04

Akos Kitta added 4 commits May 31, 2022 16:41
Reverted titleBarStyling for Windows/Linux.
0e4881c 
Otherwise the menus are not visible.

Signed-off-by: Akos Kitta <[email protected]>
workaround for the non realpath.
644bf14 
Signed-off-by: Akos Kitta <[email protected]>
Relaxed prettier on Windows.
ab56005 
Signed-off-by: Akos Kitta <[email protected]>
Workaround for non-realpaths on Windows.
8a04d47 
Signed-off-by: Akos Kitta <[email protected]>
@kittaakos
Copy link
Contributor Author

I am closing the PR in favor of #1018.

@kittaakos kittaakos closed this Jun 1, 2022
@per1234 per1234 added conclusion: duplicate Has already been submitted and removed status: on hold Do not proceed at this time labels Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 requested changes

Assignees
No one assigned
Labels
conclusion: duplicate Has already been submitted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kittaakos @per1234