disabled "trick" for deferring menu update.

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

Diff for: arduino-ide-extension/src/browser/boards/boards-data-menu-updater.ts

@@ -13,6 +13,7 @@ import { BoardsDataStore } from './boards-data-store';
 import { MainMenuManager } from '../../common/main-menu-manager';
 import { ArduinoMenus, unregisterSubmenu } from '../menu/arduino-menus';
 import { nls } from '@theia/core/lib/common';
+import { FrontendApplicationStateService } from '@theia/core/lib/browser/frontend-application-state';
 
 @injectable()
 export class BoardsDataMenuUpdater implements FrontendApplicationContribution {
@@ -31,11 +32,20 @@ export class BoardsDataMenuUpdater implements FrontendApplicationContribution {
   @inject(BoardsServiceProvider)
   protected readonly boardsServiceClient: BoardsServiceProvider;
 
+  @inject(FrontendApplicationStateService)
+  private readonly appStateService: FrontendApplicationStateService;
+
   protected readonly queue = new PQueue({ autoStart: true, concurrency: 1 });
   protected readonly toDisposeOnBoardChange = new DisposableCollection();
 
   async onStart(): Promise<void> {
-    this.updateMenuActions(this.boardsServiceClient.boardsConfig.selectedBoard);
+    this.appStateService
+      .reachedState('ready')
+      .then(() =>
+        this.updateMenuActions(
+          this.boardsServiceClient.boardsConfig.selectedBoard
+        )
+      );
     this.boardsDataStore.onChanged(() =>
       this.updateMenuActions(
         this.boardsServiceClient.boardsConfig.selectedBoard

Diff for: arduino-ide-extension/src/browser/contributions/board-selection.ts

@@ -101,16 +101,14 @@ PID: ${PID}`;
   }
 
   override onStart(): void {
-    this.notificationCenter.onPlatformInstalled(this.updateMenus.bind(this));
-    this.notificationCenter.onPlatformUninstalled(this.updateMenus.bind(this));
-    this.boardsServiceProvider.onBoardsConfigChanged(
-      this.updateMenus.bind(this)
+    this.notificationCenter.onPlatformInstalled(() => this.updateMenus());
+    this.notificationCenter.onPlatformUninstalled(() => this.updateMenus());
+    this.boardsServiceProvider.onBoardsConfigChanged(() => this.updateMenus());
+    this.boardsServiceProvider.onAvailableBoardsChanged(() =>
+      this.updateMenus()
     );
-    this.boardsServiceProvider.onAvailableBoardsChanged(
-      this.updateMenus.bind(this)
-    );
-    this.boardsServiceProvider.onAvailablePortsChanged(
-      this.updateMenus.bind(this)
+    this.boardsServiceProvider.onAvailablePortsChanged(() =>
+      this.updateMenus()
     );
   }
 

Diff for: arduino-ide-extension/src/electron-browser/theia/core/electron-menu-contribution.ts

@@ -18,16 +18,16 @@ export class ElectronMenuContribution
   @inject(FrontendApplicationStateService)
   private readonly appStateService: FrontendApplicationStateService;
 
-  private appReady = false;
-  private updateWhenReady = false;
+  // private appReady = false;
+  // private updateWhenReady = false;
 
   override onStart(app: FrontendApplication): void {
     super.onStart(app);
     this.appStateService.reachedState('ready').then(() => {
-      this.appReady = true;
-      if (this.updateWhenReady) {
-        this.update();
-      }
+      // this.appReady = true;
+      // if (this.updateWhenReady) {
+      //   this.update();
+      // }
     });
   }
 
@@ -37,11 +37,11 @@ export class ElectronMenuContribution
   }
 
   update(): void {
-    if (this.appReady) {
-      (this as any).setMenu();
-    } else {
-      this.updateWhenReady = true;
-    }
+    (this as any).setMenu();
+    // if (this.appReady) {
+    // } else {
+    //   this.updateWhenReady = true;
+    // }
   }
 
   override registerCommands(registry: CommandRegistry): void {

Diff for: arduino-ide-extension/src/node/arduino-daemon-impl.ts

@@ -41,7 +41,7 @@ export class ArduinoDaemonImpl
   // Backend application lifecycle.
 
   onStart(): void {
-    this.startDaemon();
+    this.startDaemon(); // no await
   }
 
   // Daemon API