-
-
Notifications
You must be signed in to change notification settings - Fork 4
Download provisioning binaries from aws #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
eclipse1985
reviewed
Dec 3, 2021
glumia
reviewed
Dec 3, 2021
glumia
reviewed
Dec 3, 2021
d85202e
to
0efe997
Compare
glumia
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! (and thanks for the patience, I know that sometimes I can be annoying on reviews 🙈)
Co-authored-by: Giuseppe Lumia <[email protected]>
Co-authored-by: Giuseppe Lumia <[email protected]>
Co-authored-by: Giuseppe Lumia <[email protected]>
Co-authored-by: Giuseppe Lumia <[email protected]>
475a255
to
7edd8d5
Compare
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
This completes the task of decoupling provisioning binaries from the repo. - Now users can use the 'device create' commands from any directory, since binaries are no more tied to a certain folder - Binaries can be updated without requiring a new release of the cli Changes: - provisioning binaries are now downloaded instead of being searched in the binaries folder - binaries folder has been removed - binaries are removed from the release process
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
This completes the task of decoupling provisioning binaries from the repo. - Now users can use the 'device create' commands from any directory, since binaries are no more tied to a certain folder - Binaries can be updated without requiring a new release of the cli Changes: - provisioning binaries are now downloaded instead of being searched in the binaries folder - binaries folder has been removed - binaries are removed from the release process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
we want to decouple actual binaries from this repo, this brings the following advantages:
device create
from any directory, since binaries are no more tied to a certain folderChange description
binaries
folderbinaries
folder has been removedthe upload of binaries has been implemented in other pr #70