Skip to content

Download provisioning binaries from aws #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Dec 10, 2021
Merged

Conversation

polldo
Copy link
Contributor

@polldo polldo commented Dec 2, 2021

Motivation

we want to decouple actual binaries from this repo, this brings the following advantages:

  • users can use the device create from any directory, since binaries are no more tied to a certain folder
  • binaries can be updated without requiring a new release of the cli

Change description

  • provisioning binaries are now downloaded instead of being searched in the binaries folder
  • binaries folder has been removed

the upload of binaries has been implemented in other pr #70

@polldo polldo mentioned this pull request Dec 2, 2021
@polldo polldo requested review from glumia and eclipse1985 December 2, 2021 16:27
@glumia glumia mentioned this pull request Dec 7, 2021
6 tasks
@polldo polldo force-pushed the polldo/download-binaries branch from d85202e to 0efe997 Compare December 9, 2021 14:26
Copy link
Contributor

@glumia glumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! (and thanks for the patience, I know that sometimes I can be annoying on reviews 🙈)

@polldo polldo force-pushed the polldo/download-binaries branch from 475a255 to 7edd8d5 Compare December 10, 2021 17:01
@polldo polldo merged commit d143c39 into main Dec 10, 2021
@polldo polldo deleted the polldo/download-binaries branch December 10, 2021 17:09
polldo pushed a commit that referenced this pull request Sep 2, 2022
This completes the task of decoupling provisioning binaries from the repo.
- Now users can use the 'device create' commands from any directory, since binaries are no more tied to a certain folder
- Binaries can be updated without requiring a new release of the cli
Changes:
- provisioning binaries are now downloaded instead of being searched in the binaries folder
- binaries folder has been removed
- binaries are removed from the release process
polldo pushed a commit that referenced this pull request Sep 2, 2022
This completes the task of decoupling provisioning binaries from the repo.
- Now users can use the 'device create' commands from any directory, since binaries are no more tied to a certain folder
- Binaries can be updated without requiring a new release of the cli
Changes:
- provisioning binaries are now downloaded instead of being searched in the binaries folder
- binaries folder has been removed
- binaries are removed from the release process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants