Skip to content

Add device list-fqbn command #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 10, 2021
Merged

Add device list-fqbn command #78

merged 6 commits into from
Dec 10, 2021

Conversation

polldo
Copy link
Contributor

@polldo polldo commented Dec 6, 2021

Motivation

built on top of #77
Since during device creation users can specify an FQBN, we want to provide them with a command to retrieve a list of supported FQBN.

Change description

Add command device list-fqbn that returns a list of supported fqbn. This list is fetched from https://builder.arduino.cc/v3/boards/ endpoint

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@polldo polldo requested review from eclipse1985 and glumia December 6, 2021 14:45
@polldo polldo force-pushed the polldo/device-list-fqbn branch from 9b37207 to 35a2173 Compare December 6, 2021 14:57
@glumia glumia changed the base branch from main to polldo/device-generic December 7, 2021 10:44
Copy link
Contributor

@glumia glumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Contributor

@eclipse1985 eclipse1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from polldo/device-generic to main December 10, 2021 17:22
@polldo polldo force-pushed the polldo/device-list-fqbn branch from e88beeb to 8b3485c Compare December 10, 2021 17:31
@polldo polldo merged commit 0442405 into main Dec 10, 2021
@polldo polldo deleted the polldo/device-list-fqbn branch December 10, 2021 17:34
polldo pushed a commit that referenced this pull request Sep 2, 2022
Add a command to retrieve the list of FQBN supported by arduino iot cloud
polldo pushed a commit that referenced this pull request Sep 2, 2022
Add a command to retrieve the list of FQBN supported by arduino iot cloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants