Sync binaries on aws #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polldo
force-pushed
the
polldo/sync-bins
branch
4 times, most recently
from
4d50b27 to
b21cf26
Compare
polldo
force-pushed
the
polldo/sync-bins
branch
7 times, most recently
from
d97c22c to
20e7804
Compare
polldo
force-pushed
the
polldo/sync-bins
branch
4 times, most recently
from
c09333a to
69e9bfd
Compare
eclipse1985
approved these changes
Dec 3, 2021
eclipse1985
reviewed
Dec 3, 2021
|
Where do those provision sketches come from? |
glumia
reviewed
Dec 3, 2021
There was a problem hiding this comment.
Added some suggestions to improve readability and (a bit) robustness of the Python script.
We could also add the following lines to the .gitignore for the generated provisioning stuff:
# Provisioning binaries and metadata
firmware/binaries
firmware/provision/**/build
from the old provisioning python script |
polldo
force-pushed
the
polldo/sync-bins
branch
from
2d93b48 to
c74654c
Compare
polldo
force-pushed
the
polldo/sync-bins
branch
from
c5c0ee9 to
5eac31c
Compare
glumia
approved these changes
Dec 10, 2021
eclipse1985
approved these changes
Dec 10, 2021
Co-authored-by: Giuseppe Lumia <[email protected]>
Co-authored-by: Giuseppe Lumia <[email protected]>
polldo
force-pushed
the
polldo/sync-bins
branch
from
5eac31c to
48d915a
Compare
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
This is the first step to decouple actual provisioning binaries from this repo The provisioning sketches have been introduced in the repo: whenever a change is made on the sketches, the CI will regenerate and upload the new binaries on aws.
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
This is the first step to decouple actual provisioning binaries from this repo The provisioning sketches have been introduced in the repo: whenever a change is made on the sketches, the CI will regenerate and upload the new binaries on aws.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
we want to decouple actual binaries from this repo, this brings the following advantages:
device createfrom any directory, since binaries are no more tied to a certain folderChange description
the actual download of the binaries has been implemented in other pr #74