GRPC serial monitor: Fix unhandled error (EINTR) that leaves serial port open
#507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes a fix to serial.Read method. Should fix: arduino#504 Actual patch: bugst/go-serial#69
|
I am trying it right now and will use this version of CLI for arduino/arduino-pro-ide#112. I will update this PR if I find any issues. Thank you for your help, @cmaglie! |
|
After looking into the changeset; I would have expected a |
I haven't experienced any issues, will be doing additional verifications during the development tomorrow. Very very promising fix 🙏 |
|
@cmaglie, I have been using this version of CLI since yesterday and haven't had any issues with it. Awesome 🎉, +1 for merging it. |
masci
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update go-serial library to latest version, includes a fix to serial.Read method.
Should fix: #504
Actual patch: bugst/go-serial#69
@kittaakos