-
-
Notifications
You must be signed in to change notification settings - Fork 398
[serial-monitor][gRPC] Unhandled EINTR
error leaves the serial port opened
#504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This was reported independently by a PRO IDE user: arduino/arduino-pro-ide#157 |
cmaglie
added a commit
to cmaglie/go-serial
that referenced
this issue
Dec 3, 2019
This has been observed in particular on MacOS, in this case just retry the call without throwing the error back to the user. Related to: arduino/arduino-cli#504 arduino/arduino-pro-ide#157
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this issue
Dec 3, 2019
Includes a fix to serial.Read method. Should fix: arduino#504 Actual patch: bugst/go-serial#69
cmaglie
added a commit
that referenced
this issue
Dec 6, 2019
… port open (#507) * Update go-serial library to latest version Includes a fix to serial.Read method. Should fix: #504 Actual patch: bugst/go-serial#69 * Using versioned release of go.bug.st/serial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
Current behavior
There are two issues here:
select
andread
can throw the following errors:EINTR
,EAGAIN
, andEWOULDBLOCK
. These should be handled ingo-serial
and the CLI should recover and continue on such errors.arduino-cli/commands/daemon/monitor.go
Lines 130 to 131 in da8fc05
Expected behavior
EINTR
, andEAGAIN
should be handled. After an error, clients can open a new client streaming duplex for the serial monitor.Environment
arduino-cli version
): From sourceAdditional context
The text was updated successfully, but these errors were encountered: