Skip to content

Serial connection closes after receiving interrupted system call #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
petrica opened this issue Jan 28, 2021 · 6 comments · Fixed by #610
Closed

Serial connection closes after receiving interrupted system call #609

petrica opened this issue Jan 28, 2021 · 6 comments · Fixed by #610
Assignees
Labels
type: imperfection Perceived defect in any part of project

Comments

@petrica
Copy link

petrica commented Jan 28, 2021

Bug Report

Describe the bug

After opening the serial monitor and reading data from an Arduino, if the amount of data is consistent and protracted in time, an interrupted system call error closes the serial connection.

To Reproduce

Write an Arduino sketch that sends data continuously to the serial monitor.

Expected behavior

Connection is kept opened and data is received.

Environment (please complete the following information):

  • OS: macOs
  • OS Version: Catalina 10.15.7
  • Browser: Chrome
  • Browser Version: 87.0.4280.141
  • Agent Version: 1.2.0-5c796d2

Additional context

This bug seems to have been present in the Arduino CLI as well and got resolved by upgrading the bugst/go-serial library to latest version.

Arduino CLI similar issue here: arduino/arduino-cli#507

bugst/go-serial version that handles the interrupt: bugst/go-serial@6a673bf

@zmoog
Copy link
Contributor

zmoog commented Jan 29, 2021

Hey @petrica thank you for the troubleshooting, kudos!

We're opening a PR to build a test version of the Agent so you can test it..

@petrica
Copy link
Author

petrica commented Jan 29, 2021

Sure, I have already downloaded the source code and tested it replacing the go.bug.st/serial.v1 import with go.bug.st/serial. Interestingly enough, although go.bug.st/serial.v1 refers to v1 of the library, it does not reference the code under v1.0.0 where the fix is.

Once the PR is ready, I'll give another go. Thanks!

@umbynos umbynos linked a pull request Jan 29, 2021 that will close this issue
2 tasks
@zmoog
Copy link
Contributor

zmoog commented Jan 29, 2021

We have a 1.2.1 release coming so if your test is successful we can ship it to all users.

Thank you! 🙇

@umbynos
Copy link
Contributor

umbynos commented Jan 29, 2021

https://github.com/arduino/arduino-create-agent/actions/runs/521166778
Here's the artifacts, download the binaries and please tell us if this solves the problem 🐛 ⚡

@petrica
Copy link
Author

petrica commented Jan 29, 2021

Running this successfully for the past 10 minutes. Usually it stopped in less than a minute.

Tested arduino-create-agent-macos-10.15-amd64.zip artifact on MacOS Catalina 10.15.7.

Thank you for the quick reaction to this issue!

@umbynos
Copy link
Contributor

umbynos commented Jan 29, 2021

Thank you for taking the time to report a so detailed issue!! 💌
I will merge the PR right now! This fix will be part of the 1.2.1 incoming release.

@umbynos umbynos closed this as completed Jan 29, 2021
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants