Skip to content

Boards manager package_index.json checksum only works if lower case #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rogerclarkmelbourne opened this issue Apr 10, 2015 · 1 comment
Closed

Boards manager package_index.json checksum only works if lower case #2953

rogerclarkmelbourne opened this issue Apr 10, 2015 · 1 comment
Labels
Component: Board/Lib Manager Boards Manager or Library Manager Type: Bug

Comments

@rogerclarkmelbourne
Copy link

It appears that the checksum calculator used by the Boards Manager, only works if the checksum in package_index.json is lower case

e.g. this works

"checksum": "SHA-256:2909a4c6dd6d7497e7e1b5fcaa2f66a100271417510f3a68593b65af8ff78c1c",

However this does not work

"checksum": "SHA-256:2909A4C6DD6D7497E7E1B5FCAA2F66A100271417510F3A68593B65AF8FF78C1C",

I suspect your internal CRC generator code generates a lower case string, and you are doing case sensitive compare.

It would be best if it was case insensitive, as often CRC generator programs create upper case checksums
@ffissore
Copy link
Contributor

Fixed. Nightly build will be ready in the next few hours

oriregev added a commit to oriregev/Arduino that referenced this issue Apr 27, 2015
@oriregev
Merge remote-tracking branch 'upstream/master'
33ee7bf 
* upstream/master: (239 commits)
  Fix for issue arduino#292
  Windows: build_pull_request needed to be upgraded as well
  Update revisions.txt
  Windows: JRE is chosen at build time via WINDOWS_BUNDLED_JVM property
  Update Tone.cpp
  Update revisions.txt
  Block discovery threads until packages is not null, otherwise boards discovered during startup will miss model name
  Also SerialDiscovery was affected by bug found at 40535df. Fixes arduino#2892
  NetworkDiscovery was silently failing because packages werenìt ready yet. Fixes arduino#2837
  Better preference for setting warnings level. See arduino@61592d7#commitcomment-10668365
  SAM boards stop compiling due to way of handling params with spaces on different OSs. Fixed
  Update Tone.cpp
  Restored error messages. Got rid of MessageSyphon as ther were losing some error messages. Fixes arduino#2737
  Windows: added listComPorts test case
  New preference: enable all compiler warnings, off by default. Fixes arduino#1728 and arduino#2415. Also affects arduino#2634 and arduino#2207
  build.xml: spreading failonerror on all exec tasks, it's better to crash early
  Lib/Board Manager CRC check is now case insensitive. Fixes arduino#2953
  License fix to audio library
  License fix
  Library Manager: better error message
  ...
@per1234 per1234 added Component: Board/Lib Manager Boards Manager or Library Manager Type: Bug labels Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Board/Lib Manager Boards Manager or Library Manager Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ffissore @rogerclarkmelbourne @per1234