NetworkDiscovery was silently failing because packages werenìt ready yet. Fixes arduino#2837

Author: Federico Fissore

Diff for: arduino-core/src/cc/arduino/packages/discoverers/NetworkDiscovery.java

@@ -137,7 +137,7 @@ public void serviceResolved(ServiceEvent serviceEvent) {
       }
 
       String label = name + " at " + address;
-      if (board != null) {
+      if (board != null && BaseNoGui.packages != null) {
         String boardName = BaseNoGui.getPlatform().resolveDeviceByBoardID(BaseNoGui.packages, board);
         if (boardName != null) {
           label += " (" + boardName + ")";

Diff for: arduino-core/src/processing/app/Platform.java

@@ -164,6 +164,8 @@ protected Map<String, Object> resolveDeviceByVendorIdProductId(Map<String, Targe
   }
 
   public String resolveDeviceByBoardID(Map<String, TargetPackage> packages, String boardId) {
+    assert packages != null;
+    assert boardId != null;
     for (TargetPackage targetPackage : packages.values()) {
       for (TargetPlatform targetPlatform : targetPackage.getPlatforms().values()) {
         for (TargetBoard board : targetPlatform.getBoards().values()) {