Skip to content

FYI #error and #warning on Nightly build 1.5.8 #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JulyJim opened this issue Nov 5, 2014 · 3 comments
Closed

FYI #error and #warning on Nightly build 1.5.8 #2415

JulyJim opened this issue Nov 5, 2014 · 3 comments
Labels
Component: Compilation Related to compilation of Arduino sketches Type: Bug Type: Regression Something that used to work and now doesn't
Milestone
Release 1.6.1

Comments

@JulyJim
Copy link

JulyJim commented Nov 5, 2014

Just minor stuff
The #error does not stops compiler - it should , right? It works on "regular " 1.5.8 stopping the compiler

warning gets not reaction from compiler - on both Nightly ( Nov 4) and regular 1.5.8. It should just print the message attached.
@matthijskooijman
Copy link
Collaborator

The hidden warnings are the subject of #1728.

AFAICS, #error should indeed stop the compilation, so I'm surprised it doesn't and especially that something changed since 1.5.8. This needs some looking at.

@matthijskooijman matthijskooijman added Component: Compilation Related to compilation of Arduino sketches Type: Bug Type: Regression Something that used to work and now doesn't Version: 1.5.x labels Nov 5, 2014
@matthijskooijman matthijskooijman added this to the Release 1.5.9 milestone Nov 5, 2014
@cmaglie cmaglie modified the milestones: Release 1.6.0, Release 1.6.1 Feb 18, 2015
ffissore pushed a commit that referenced this issue Apr 10, 2015
New preference: enable all compiler warnings, off by default. Fixes #…
61592d7 
…1728 and #2415. Also affects #2634 and #2207
@ffissore
Copy link
Contributor

#error does indeed stop the compiler (at least with 1.6.3)
I've added a new preference "show all compiler warnings" that turns warnings on
Available as nightly builds in the next few hours

@JulyJim
Copy link
Author

JulyJim commented Apr 10, 2015

Thanks for your work.

I am not sure why a semi-serious developer AKA coding more that "blink LED" would NOT want all helpful stuff from compiler.
But that is why we have "defaults" , right?

Thanks again.

oriregev added a commit to oriregev/Arduino that referenced this issue Apr 27, 2015
@oriregev
Merge remote-tracking branch 'upstream/master'
33ee7bf 
* upstream/master: (239 commits)
  Fix for issue arduino#292
  Windows: build_pull_request needed to be upgraded as well
  Update revisions.txt
  Windows: JRE is chosen at build time via WINDOWS_BUNDLED_JVM property
  Update Tone.cpp
  Update revisions.txt
  Block discovery threads until packages is not null, otherwise boards discovered during startup will miss model name
  Also SerialDiscovery was affected by bug found at 40535df. Fixes arduino#2892
  NetworkDiscovery was silently failing because packages werenìt ready yet. Fixes arduino#2837
  Better preference for setting warnings level. See arduino@61592d7#commitcomment-10668365
  SAM boards stop compiling due to way of handling params with spaces on different OSs. Fixed
  Update Tone.cpp
  Restored error messages. Got rid of MessageSyphon as ther were losing some error messages. Fixes arduino#2737
  Windows: added listComPorts test case
  New preference: enable all compiler warnings, off by default. Fixes arduino#1728 and arduino#2415. Also affects arduino#2634 and arduino#2207
  build.xml: spreading failonerror on all exec tasks, it's better to crash early
  Lib/Board Manager CRC check is now case insensitive. Fixes arduino#2953
  License fix to audio library
  License fix
  Library Manager: better error message
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Compilation Related to compilation of Arduino sketches Type: Bug Type: Regression Something that used to work and now doesn't
Projects
None yet
Milestone
Release 1.6.1
Development

No branches or pull requests
4 participants
@matthijskooijman @cmaglie @ffissore @JulyJim