Add support for Snowflake account privileges #1666
Conversation
| #[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)] | ||
| #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] | ||
| #[cfg_attr(feature = "visitor", derive(Visit, VisitMut))] | ||
| pub enum ActionCreateObjectType { |
There was a problem hiding this comment.
Could we add a link to the docs for the introduced enums? I'm thinking since there's a lot of them, especially in the parsing code it'll be useful to know where the syntax is coming from for reference
|
Hi @yoavcloud -- thank you for all these PRs / features 🙏 Given you are so active in the project and now are quite familar with the code, perhaps you might be interested in helping review other contributor PRs as well? To do so just leave a review and then tag @iffyio and/or myself The goal would would be to get the PR to point where we can just approve it and merge. I think the big things to check for would be test coverage and style consistency with the rest of the crate |
yoavcloud
force-pushed
the
sf_privileges
branch
from
6c6af75 to
e30755f
Compare
Hey @alamb I'd like that, yes. Let me try and see how it goes :-) |
Thanks @yoavcloud -- I look forward to continuted collaboration. This is going to be great |
…o escape-literals * 'main' of github.com:hansott/datafusion-sqlparser-rs: National strings: check if dialect supports backslash escape (apache#1672) Add support for Create Iceberg Table statement for Snowflake parser (apache#1664) Add support for Snowflake account privileges (apache#1666) Update rat_exclude_file.txt (apache#1670) Update verson to 0.54.0 and update changelog (apache#1668) Add support for Snowflake AT/BEFORE (apache#1667) Add support for qualified column names in JOIN ... USING (apache#1663) Add support for `IS [NOT] [form] NORMALIZED` (apache#1655) fix parsing of `INSERT INTO ... SELECT ... RETURNING ` (apache#1661) Add support for Snowflake column aliases that use SQL keywords (apache#1632)
This reverts commit b441abd.
This PR mostly handles the following part of the GRANT syntax on Snowflake: https://docs.snowflake.com/en/sql-reference/sql/grant-privilege