Add support for IS [NOT] [form] NORMALIZED
#1655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
force-pushed
the
is-normalized
branch
7 times, most recently
from
1ff1908 to
c36a23b
Compare
alexander-beedie
force-pushed
the
is-normalized
branch
from
c36a23b to
b24b958
Compare
alamb
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Thank you @alexander-beedie -- I think this looks quite nice and well tested
fyi @iffyio
| @@ -1118,7 +1124,7 @@ impl fmt::Display for LambdaFunction { | |||
| /// `OneOrManyWithParens` implements `Deref<Target = [T]>` and `IntoIterator`, | |||
| /// so you can call slice methods on it and iterate over items | |||
| /// # Examples | |||
| /// Acessing as a slice: | |||
| /// Accessing as a slice: | |||
There was a problem hiding this comment.
Thank you for these cleanups
iffyio
reviewed
Jan 17, 2025
iffyio
approved these changes
Jan 17, 2025
hansott
added a commit
to hansott/datafusion-sqlparser-rs
that referenced
this pull request
Jan 23, 2025
…o escape-literals * 'main' of github.com:hansott/datafusion-sqlparser-rs: National strings: check if dialect supports backslash escape (apache#1672) Add support for Create Iceberg Table statement for Snowflake parser (apache#1664) Add support for Snowflake account privileges (apache#1666) Update rat_exclude_file.txt (apache#1670) Update verson to 0.54.0 and update changelog (apache#1668) Add support for Snowflake AT/BEFORE (apache#1667) Add support for qualified column names in JOIN ... USING (apache#1663) Add support for `IS [NOT] [form] NORMALIZED` (apache#1655) fix parsing of `INSERT INTO ... SELECT ... RETURNING ` (apache#1661) Add support for Snowflake column aliases that use SQL keywords (apache#1632)
Vedin
pushed a commit
to Embucket/datafusion-sqlparser-rs
that referenced
this pull request
Feb 3, 2025
Co-authored-by: Alexander Beedie <[email protected]>
Vedin
pushed a commit
to Embucket/datafusion-sqlparser-rs
that referenced
this pull request
Feb 3, 2025
Co-authored-by: Alexander Beedie <[email protected]>
Vedin
added a commit
to Embucket/datafusion-sqlparser-rs
that referenced
this pull request
Feb 3, 2025
This reverts commit 2741fd0.
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Apr 10, 2025
Co-authored-by: Alexander Beedie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds parsing support for
IS [NOT] [<form>] NORMALIZED → boolsyntax:Details from the PostgreSQL string function docs:
https://www.postgresql.org/docs/current/functions-string.html
NFC: Canonical Decomposition, followed by Canonical Composition.NFD: Canonical Decomposition.NFKC: Compatibility Decomposition, followed by Canonical Composition.NFKD: Compatibility Decomposition.As the normalised forms are fixed (there are only these four), it seemed reasonable to return the parsed form as a new
Option<NormalizationForm>Enum (which helps the caller as they don't have to check the string or case-normalise it, and can then jump straight into some associated match block, etc).(Also: fixed a few minor typos).
Examples
Default/omitted
form:Specific
form: