Add support for qualified column names in JOIN ... USING #1663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoavcloud
force-pushed
the
sf_join_using_qualified_cols
branch
from
3b4b69e to
22182a2
Compare
iffyio
reviewed
Jan 18, 2025
src/parser/mod.rs
Outdated
| allow_empty: bool, | ||
| ) -> Result<Vec<ObjectName>, ParserError> { | ||
| self.parse_parenthesized_column_list_inner(optional, allow_empty, |p| { | ||
| p.parse_object_name(false) |
There was a problem hiding this comment.
Should the in_table_clause be configurable here? I thinking it's supposed to be set to true when parsing a USING clause given the behavior being fixed
tests/sqlparser_snowflake.rs
Outdated
Comment on lines
2654
to
2655
| // Snowflake allows fully-qualified column names inside USING | ||
| snowflake().verified_stmt("SELECT * FROM tbl1 AS t1 JOIN tbl2 AS t2 USING(t2.col1)"); |
There was a problem hiding this comment.
maybe we can add this scenario to the parse_joins_using test in common.rs instead?
src/parser/mod.rs
Outdated
| self.parse_parenthesized_column_list_inner(optional, allow_empty, |p| p.parse_identifier()) | ||
| } | ||
|
|
||
| /// Parses a parenthesized comma-separated list of unqualified, possibly quoted identifiers |
There was a problem hiding this comment.
The doc comment doesn't seem to match the behavior (unqualified vs qualified)? also it could be nice if the doc highlights that the parenthesis is also expected in the input (maybe with an example)
iffyio
approved these changes
Jan 19, 2025
hansott
added a commit
to hansott/datafusion-sqlparser-rs
that referenced
this pull request
Jan 23, 2025
…o escape-literals * 'main' of github.com:hansott/datafusion-sqlparser-rs: National strings: check if dialect supports backslash escape (apache#1672) Add support for Create Iceberg Table statement for Snowflake parser (apache#1664) Add support for Snowflake account privileges (apache#1666) Update rat_exclude_file.txt (apache#1670) Update verson to 0.54.0 and update changelog (apache#1668) Add support for Snowflake AT/BEFORE (apache#1667) Add support for qualified column names in JOIN ... USING (apache#1663) Add support for `IS [NOT] [form] NORMALIZED` (apache#1655) fix parsing of `INSERT INTO ... SELECT ... RETURNING ` (apache#1661) Add support for Snowflake column aliases that use SQL keywords (apache#1632)
Vedin
pushed a commit
to Embucket/datafusion-sqlparser-rs
that referenced
this pull request
Feb 3, 2025
Vedin
pushed a commit
to Embucket/datafusion-sqlparser-rs
that referenced
this pull request
Feb 3, 2025
Vedin
added a commit
to Embucket/datafusion-sqlparser-rs
that referenced
this pull request
Feb 3, 2025
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that Snowflake allows specifying qualified column names in the USING column list. For example:
SELECT * FROM tbl1 AS t1 JOIN tbl2 AS t2 USING(t2.col1)BTW, it's worthwhile exploring changing all occurrences to parse column lists as Vec instead of Vec, there are likely other statement patterns that get rejected...