LUT element support #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maciej Kurc <[email protected]>
mkurc-ant
force-pushed
the
mkurc/luts
branch
2 times, most recently
from
d80af6c to
b01b7a1
Compare
Signed-off-by: Maciej Kurc <[email protected]>
Signed-off-by: Maciej Kurc <[email protected]>
Signed-off-by: Maciej Kurc <[email protected]>
Signed-off-by: Maciej Kurc <[email protected]>
acomodi
suggested changes
Dec 15, 2021
Comment on lines
+53
to
+83
| namespace vtr { | ||
| static char* stringf(const char* format, ...) { | ||
| // Initial buffer | ||
| const int initialSize = 80 + 1; | ||
| char* str = (char*)vtr::malloc(initialSize); | ||
|
|
||
| // Init and copy args list | ||
| va_list va1, va2; | ||
| va_start(va1, format); | ||
| va_copy(va2, va1); | ||
|
|
||
| // First attempt | ||
| int len = vsnprintf(str, initialSize, format, va1); | ||
| VTR_ASSERT(len >= 0); | ||
|
|
||
| // The buffer was too small | ||
| if (len >= initialSize) { | ||
| str = (char*)vtr::realloc((void*)str, len + 1); | ||
| VTR_ASSERT(str != nullptr); | ||
| len = vsnprintf(str, len + 1, format, va2); | ||
| VTR_ASSERT(len >= 0); | ||
| VTR_ASSERT(len <= len); | ||
| } | ||
|
|
||
| // Cleanup | ||
| va_end(va1); | ||
| va_end(va2); | ||
|
|
||
| return str; | ||
| } | ||
| } // namespace vtr |
There was a problem hiding this comment.
I believe this should end up in libvtrutils (or sth similar)
|
I have added the changes from this PR to the one open upstream: verilog-to-routing#1937. I have adapted the changes to solve some issues with xc7 and nexus devices, for instance the fact that the LUT bels of the "memory" type SLICEs can have other BEL pins, not taken into account in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for LUT elements.
A LUT element is modeled as a pb_type with one mode per each LUT BEL from the element. This is suboptimal as it doesn't allow to pack eg. two smaller LUTs together into a fractuable LUT element but it is ok as a starting point for future improvements.
Each individual LUT (inside its mode) has two modes: one for a LUT-thru and another for the actual LUT bel.