Fixes to FPGA interchange arch reader #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in model building Signed-off-by: Maciej Kurc <[email protected]>
…ility functions for dumping pb_type hierarchy as it is being built. Signed-off-by: Maciej Kurc <[email protected]>
Signed-off-by: Maciej Kurc <[email protected]>
…ge architecture, added a function for checking correctness. Signed-off-by: Maciej Kurc <[email protected]>
…s) and physical tiles. Signed-off-by: Maciej Kurc <[email protected]>
acomodi
reviewed
Jun 9, 2022
Comment on lines
+1553
to
+1590
| if (is_out) { | ||
| auto* omode = &pad->modes[mode_idx]; | ||
| omode->name = vtr::strdup("opad"); | ||
| omode->parent_pb_type = pad; | ||
| omode->index = mode_idx; | ||
|
|
||
| omode->num_pb_type_children = 1; | ||
| omode->pb_type_children = new t_pb_type[1]; | ||
| auto* opad = &omode->pb_type_children[0]; | ||
| opad->name = vtr::strdup("opad"); | ||
| opad->num_pb = 1; | ||
| opad->parent_mode = omode; | ||
|
|
||
| num_ports = 1; | ||
| opad->num_ports = num_ports; | ||
| opad->ports = (t_port*)vtr::calloc(num_ports, sizeof(t_port)); | ||
| opad->blif_model = vtr::strdup(MODEL_OUTPUT); | ||
| opad->model = get_model(arch_, std::string(MODEL_OUTPUT)); | ||
|
|
||
| opad->ports[0] = get_generic_port(arch_, opad, IN_PORT, "outpad", MODEL_OUTPUT); | ||
|
|
||
| omode->num_interconnect = 1; | ||
| omode->interconnect = new t_interconnect[1]; | ||
| auto* o_ic = &omode->interconnect[0]; | ||
|
|
||
| std::string opad_istr = std::string(pad->name) + std::string(".") + ipin; | ||
| std::string opad_ostr = std::string(opad->name) + std::string(".outpad"); | ||
| std::string o_ic_name = std::string(pad->name) + std::string("_") + std::string(opad->name); | ||
|
|
||
| o_ic->name = vtr::strdup(o_ic_name.c_str()); | ||
| o_ic->type = DIRECT_INTERC; | ||
| o_ic->parent_mode_index = mode_idx; | ||
| o_ic->parent_mode = omode; | ||
| o_ic->input_string = vtr::strdup(opad_istr.c_str()); | ||
| o_ic->output_string = vtr::strdup(opad_ostr.c_str()); | ||
|
|
||
| mode_idx++; | ||
| } |
There was a problem hiding this comment.
I wonder if this can actually be generalized somehow, so that we do not repeat code for both inp and out
There was a problem hiding this comment.
Yeah, so I haven't checked that on 7-series yet. I'll do that.
There was a problem hiding this comment.
Unfortunately it does not work on xc7 ... The problem is that sub_tile names do not match complex block names in some cases. I'm debugging why it happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the FPGA inerchange arch reader:
newwithmallocetc.)