This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor($http) Use onload/onerror/onabort instead of onreadystatechange #9329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realityking
force-pushed
the
xhrEvents
branch
from
7c417e2 to
3f791fd
Compare
realityking
force-pushed
the
xhrEvents
branch
from
3f791fd to
27b9981
Compare
…ons of Internet Explorer This removes a workaround for IE 8 and and error handling for IE6.
realityking
force-pushed
the
xhrEvents
branch
from
27b9981 to
fa2634c
Compare
|
landed. thanks! |
IgorMinar
pushed a commit
that referenced
this pull request
Oct 7, 2014
bullgare
pushed a commit
to bullgare/angular.js
that referenced
this pull request
Oct 9, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #9300 and includes the commit form that pull request. This should only be merged once the #9300 has been merged but I'd like some early feedback.
By using the newer unload/onerror/onabort events the code can be made much more readable and a number of browser workarounds can be dropped.
I confirmed using the iOS simulator that #5426 does not happen with the unload event.
I suspect that this is also a bit faster, since the browser has to call events less often but that's going to be negligible.