This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor($http) Simplify code by removing the createXhr() method #9300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realityking
force-pushed
the
xhr
branch
2 times, most recently
from
3acad64 to
e2ce50e
Compare
realityking
force-pushed
the
xhr
branch
2 times, most recently
from
f227e4d to
7f54aa5
Compare
|
I don't totally like this, I think it would be better for $httpBackend to continue using a factory to create the XHR rather than an actual constructor. In addition to this, even though it's true that we don't want to support IE8, there are situations where people want to customize the way an XHR is constructed (such as for B2G/gaia), and I think the current state of the tree is closer to making that work than this change would be. Why not just change it to function createXhr() {
return new XMLHttpRequest();
}instead? |
caitp
added
type: refactor
component: $http
resolution: works as expected
needs: work
and removed
resolution: works as expected
labels
|
Updated with the requested change. |
…ons of Internet Explorer This removes a workaround for IE 8 and and error handling for IE6.
IgorMinar
pushed a commit
to IgorMinar/angular.js
that referenced
this pull request
Oct 6, 2014
…ons of Internet Explorer This removes a workaround for IE 8 and and error handling for IE6. Closes angular#9300
|
Good sweep, nice and clean, keep at it! ;) |
bullgare
pushed a commit
to bullgare/angular.js
that referenced
this pull request
Oct 9, 2014
…ons of Internet Explorer This removes a workaround for IE 8 and and error handling for IE6. Closes angular#9300
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a workaround for IE 8 and and error handling for IE6. This is basically a revert of 6c17d02.
Saves 202 bytes on the minified build.