Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refactor($http) Simplify code by removing the createXhr() method #9300

Closed
wants to merge 1 commit into from
Closed

refactor($http) Simplify code by removing the createXhr() method #9300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions docs/content/error/$httpBackend/noxhr.ngdoc
View file
Open in desktop

This file was deleted.

16 changes: 3 additions & 13 deletions src/ng/httpBackend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,7 @@
'use strict';

function createXhr(method) {
//if IE and the method is not RFC2616 compliant, or if XMLHttpRequest
//is not available, try getting an ActiveXObject. Otherwise, use XMLHttpRequest
//if it is available
if (msie <= 8 && (!method.match(/^(get|post|head|put|delete|options)$/i) ||
!window.XMLHttpRequest)) {
return new window.ActiveXObject("Microsoft.XMLHTTP");
} else if (window.XMLHttpRequest) {
return new window.XMLHttpRequest();
}

throw minErr('$httpBackend')('noxhr', "This browser does not support XMLHttpRequest.");
function createXhr() {
return new window.XMLHttpRequest();
}

/**
Expand Down Expand Up @@ -59,7 +49,7 @@ function createHttpBackend($browser, createXhr, $browserDefer, callbacks, rawDoc
});
} else {

var xhr = createXhr(method);
var xhr = createXhr();

xhr.open(method, url, true);
forEach(headers, function(value, key) {
Expand Down