Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 7c417e2

Browse files
realitykingrealityking
committed
refactor($http) Use onload/onerror/onabort instead of onreadystatechange
1 parent df54780 commit 7c417e2

File tree

2 files changed

+42
-90
lines changed

2 files changed

+42
-90
lines changed

‎src/ng/httpBackend.js

+28-48
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,8 @@ function $HttpBackendProvider() {
2727
}
2828

2929
function createHttpBackend($browser, createXhr, $browserDefer, callbacks, rawDocument) {
30-
var ABORTED = -1;
31-
3230
// TODO(vojta): fix the signature
3331
return function(method, url, post, callback, headers, timeout, withCredentials, responseType) {
34-
var status;
3532
$browser.$$incOutstandingRequestCount();
3633
url = url || $browser.url();
3734

@@ -58,44 +55,39 @@ function createHttpBackend($browser, createXhr, $browserDefer, callbacks, rawDoc
5855
}
5956
});
6057

61-
// In IE6 and 7, this might be called synchronously when xhr.send below is called and the
62-
// response is in the cache. the promise api will ensure that to the app code the api is
63-
// always async
64-
xhr.onreadystatechange = function() {
65-
// onreadystatechange might get called multiple times with readyState === 4 on mobile webkit caused by
66-
// xhrs that are resolved while the app is in the background (see #5426).
67-
// since calling completeRequest sets the `xhr` variable to null, we just check if it's not null before
68-
// continuing
69-
//
70-
// we can't set xhr.onreadystatechange to undefined or delete it because that breaks IE8 (method=PATCH) and
71-
// Safari respectively.
72-
if (xhr && xhr.readyState == 4) {
73-
var responseHeaders = null,
74-
response = null,
75-
statusText = '';
76-
77-
if(status !== ABORTED) {
78-
responseHeaders = xhr.getAllResponseHeaders();
79-
80-
// responseText is the old-school way of retrieving response (supported by IE8 & 9)
81-
// response/responseType properties were introduced in XHR Level2 spec (supported by IE10)
82-
response = ('response' in xhr) ? xhr.response : xhr.responseText;
83-
}
58+
xhr.onload = function requestComplete() {
59+
var statusText = xhr.statusText || '';
8460

85-
// Accessing statusText on an aborted xhr object will
86-
// throw an 'c00c023f error' in IE9 and lower, don't touch it.
87-
if (!(status === ABORTED && msie < 10)) {
88-
statusText = xhr.statusText;
89-
}
61+
// responseText is the old-school way of retrieving response (supported by IE8 & 9)
62+
// response/responseType properties were introduced in XHR Level2 spec (supported by IE10)
63+
var response = ('response' in xhr) ? xhr.response : xhr.responseText;
9064

91-
completeRequest(callback,
92-
status || xhr.status,
93-
response,
94-
responseHeaders,
95-
statusText);
65+
// normalize IE9 bug (http://bugs.jquery.com/ticket/1450)
66+
var status = xhr.status === 1223 ? 204 : xhr.status;
67+
68+
// fix status code when it is 0 (0 status is undocumented).
69+
// Occurs when accessing file resources or on Android 4.1 stock browser
70+
// while retrieving files from application cache.
71+
if (status === 0) {
72+
status = response ? 200 : urlResolve(url).protocol == 'file' ? 404 : 0;
9673
}
74+
75+
completeRequest(callback,
76+
status,
77+
response,
78+
xhr.getAllResponseHeaders(),
79+
statusText);
9780
};
9881

82+
var requestError = function () {
83+
// The response is always empty
84+
// See https://xhr.spec.whatwg.org/#request-error-steps and https://fetch.spec.whatwg.org/#concept-network-error
85+
completeRequest(callback, -1, null, null, '');
86+
};
87+
88+
xhr.onerror = requestError;
89+
xhr.onabort = requestError;
90+
9991
if (withCredentials) {
10092
xhr.withCredentials = true;
10193
}
@@ -128,7 +120,6 @@ function createHttpBackend($browser, createXhr, $browserDefer, callbacks, rawDoc
128120

129121

130122
function timeoutRequest() {
131-
status = ABORTED;
132123
jsonpDone && jsonpDone();
133124
xhr && xhr.abort();
134125
}
@@ -138,17 +129,6 @@ function createHttpBackend($browser, createXhr, $browserDefer, callbacks, rawDoc
138129
timeoutId && $browserDefer.cancel(timeoutId);
139130
jsonpDone = xhr = null;
140131

141-
// fix status code when it is 0 (0 status is undocumented).
142-
// Occurs when accessing file resources or on Android 4.1 stock browser
143-
// while retrieving files from application cache.
144-
if (status === 0) {
145-
status = response ? 200 : urlResolve(url).protocol == 'file' ? 404 : 0;
146-
}
147-
148-
// normalize IE bug (http://bugs.jquery.com/ticket/1450)
149-
status = status === 1223 ? 204 : status;
150-
statusText = statusText || '';
151-
152132
callback(status, response, headersString, statusText);
153133
$browser.$$completeOutstandingRequest(noop);
154134
}

‎test/ng/httpBackendSpec.js

+14-42
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,7 @@ describe('$httpBackend', function() {
8787
$backend('GET', '/some-url', null, callback);
8888
xhr = MockXhr.$$lastInstance;
8989
xhr.statusText = 'OK';
90-
xhr.readyState = 4;
91-
xhr.onreadystatechange();
90+
xhr.onload();
9291
expect(callback).toHaveBeenCalledOnce();
9392
});
9493

@@ -105,9 +104,8 @@ describe('$httpBackend', function() {
105104
expect(xhr.abort).toHaveBeenCalledOnce();
106105

107106
xhr.status = 0;
108-
xhr.readyState = 4;
109107
xhr.statusText = 'OK';
110-
xhr.onreadystatechange();
108+
xhr.onload();
111109
expect(callback).toHaveBeenCalledOnce();
112110
});
113111

@@ -118,8 +116,7 @@ describe('$httpBackend', function() {
118116

119117
$backend('GET', '/some-url', null, callback);
120118
xhr = MockXhr.$$lastInstance;
121-
xhr.readyState = 4;
122-
xhr.onreadystatechange();
119+
xhr.onload();
123120
expect(callback).toHaveBeenCalledOnce();
124121
});
125122

@@ -133,23 +130,7 @@ describe('$httpBackend', function() {
133130
xhr = MockXhr.$$lastInstance;
134131

135132
xhr.status = 1223;
136-
xhr.readyState = 4;
137-
xhr.onreadystatechange();
138-
139-
expect(callback).toHaveBeenCalledOnce();
140-
});
141-
142-
// onreadystatechange might by called multiple times
143-
// with readyState === 4 on mobile webkit caused by
144-
// xhrs that are resolved while the app is in the background (see #5426).
145-
it('should not process onreadystatechange callback with readyState == 4 more than once', function() {
146-
$backend('GET', 'URL', null, callback);
147-
xhr = MockXhr.$$lastInstance;
148-
149-
xhr.status = 200;
150-
xhr.readyState = 4;
151-
xhr.onreadystatechange();
152-
xhr.onreadystatechange();
133+
xhr.onload();
153134

154135
expect(callback).toHaveBeenCalledOnce();
155136
});
@@ -195,8 +176,7 @@ describe('$httpBackend', function() {
195176
expect(xhr.abort).toHaveBeenCalledOnce();
196177

197178
xhr.status = 0;
198-
xhr.readyState = 4;
199-
xhr.onreadystatechange();
179+
xhr.onabort();
200180
expect(callback).toHaveBeenCalledOnce();
201181
});
202182

@@ -215,8 +195,7 @@ describe('$httpBackend', function() {
215195
expect(xhr.abort).toHaveBeenCalledOnce();
216196

217197
xhr.status = 0;
218-
xhr.readyState = 4;
219-
xhr.onreadystatechange();
198+
xhr.onabort();
220199
expect(callback).toHaveBeenCalledOnce();
221200
});
222201

@@ -234,8 +213,7 @@ describe('$httpBackend', function() {
234213
expect(xhr.abort).toHaveBeenCalledOnce();
235214

236215
xhr.status = 0;
237-
xhr.readyState = 4;
238-
xhr.onreadystatechange();
216+
xhr.onabort();
239217
expect(callback).toHaveBeenCalledOnce();
240218
}));
241219

@@ -250,8 +228,7 @@ describe('$httpBackend', function() {
250228
spyOn(xhr, 'abort');
251229

252230
xhr.status = 200;
253-
xhr.readyState = 4;
254-
xhr.onreadystatechange();
231+
xhr.onload();
255232
expect(callback).toHaveBeenCalledOnce();
256233

257234
$timeout.flush();
@@ -271,16 +248,15 @@ describe('$httpBackend', function() {
271248
expect(fakeTimeout.delays[0]).toBe(2000);
272249

273250
xhr.status = 200;
274-
xhr.readyState = 4;
275-
xhr.onreadystatechange();
251+
xhr.onload();
276252
expect(callback).toHaveBeenCalledOnce();
277253

278254
expect(fakeTimeout.delays.length).toBe(0);
279255
expect(xhr.abort).not.toHaveBeenCalled();
280256
});
281257

282258

283-
it('should register onreadystatechange callback before sending', function() {
259+
it('should register callbacks before sending', function() {
284260
// send() in IE6, IE7 is sync when serving from cache
285261
function SyncXhr() {
286262
xhr = this;
@@ -289,8 +265,7 @@ describe('$httpBackend', function() {
289265
this.send = function() {
290266
this.status = 200;
291267
this.responseText = 'response';
292-
this.readyState = 4;
293-
this.onreadystatechange();
268+
this.onload();
294269
};
295270

296271
this.getAllResponseHeaders = valueFn('');
@@ -326,8 +301,7 @@ describe('$httpBackend', function() {
326301
});
327302

328303
xhrInstance.response = {some: 'object'};
329-
xhrInstance.readyState = 4;
330-
xhrInstance.onreadystatechange();
304+
xhrInstance.onload();
331305

332306
expect(callback).toHaveBeenCalledOnce();
333307
});
@@ -347,8 +321,7 @@ describe('$httpBackend', function() {
347321
});
348322

349323
xhrInstance.responseText = responseText;
350-
xhrInstance.readyState = 4;
351-
xhrInstance.onreadystatechange();
324+
xhrInstance.onload();
352325

353326
expect(callback).toHaveBeenCalledOnce();
354327
});
@@ -436,8 +409,7 @@ describe('$httpBackend', function() {
436409
xhr = MockXhr.$$lastInstance;
437410
xhr.status = status;
438411
xhr.responseText = content;
439-
xhr.readyState = 4;
440-
xhr.onreadystatechange();
412+
xhr.onload();
441413
}
442414

443415

0 commit comments

Comments
 (0)