Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Add type="url" and type="email" into the validators pipeline #7947

Closed
wants to merge 2 commits into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Jun 23, 2014

No description provided.

@matsko matsko added cla: yes and removed cla: no labels Jun 23, 2014
@rodyhaddad rodyhaddad added this to the 1.3.0 milestone Jun 23, 2014
@Narretz
Copy link
Contributor

Narretz commented Jun 23, 2014

In this commit (which is part of an equivalent pull), there's an additional test that checks if required is set when another validator is false. Might be worthwhile to add it: https://github.com/swisstofu/angular.js/commit/04c26bb1e59c0f9329a7a9ab1157a08475bc4fb3

@IgorMinar
Copy link
Contributor

lgtm. the second commit also closes #7849.

#7868 is a dupe of this PR but is not rebased correctly, so it should be easier to get this one in instead. The test that @Narretz mentioned is also part of that PR.

@IgorMinar
Copy link
Contributor

merged

@IgorMinar IgorMinar closed this Jun 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants