Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(form input): input["email"] and ngRequired not working together #7868

Closed
wants to merge 5 commits into from
Closed

Conversation

swisstofu
Copy link

ngRequired added to an email field wasn't working properly. ng-invalid-required
stayed true unless a valid email was entered.

correct behaviour is that it turns to ng-valid-required at first entered key.

closes: #7849

ngRequired added to an email field wasn't working properly. ng-invalid-required
stayed true unless a valid email was entered.

correct behaviour is that it turns to ng-valid-required at first entered key.

closes: #7849
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@swisstofu
Copy link
Author

I'm sorry I wasn't aware of that. I've applied now a few hours ago but I
didn't get any mail... not sure if it's successful then.

On Tue, Jun 17, 2014 at 3:10 PM, Mary Poppins [email protected]
wrote:

I'm sorry, but I wasn't able to verify your Contributor License Agreement
(CLA) signature. CLA signature is required for any code contributions to
AngularJS.

Please sign our CLA
https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#signing-the-cla
and ensure that the CLA signature email address and the email address in
this PR's commits match
.

If you signed the CLA as a corporation, please let us know the company's
name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses
don't match. Please sign the CLA again or update the email address in the
commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA
verification process.


Reply to this email directly or view it on GitHub
#7868 (comment).

neilsmind and others added 4 commits June 20, 2014 17:03
Update ngPluralize.js

Just a silly change to the name of one of the examples that appears to be a typo. Changing Marry to
Mary as the first would be a verb and the latter would be an extremely common name.

Closes #7884
After a protractor update the test syntax had to be changed.

Closes #7919
XHTML uses lowercase node names, while HTML often uses uppercase.  The
generally accepted convention is to always lowercase them.

Fixes #3987
@Narretz
Copy link
Contributor

Narretz commented Jun 24, 2014

This has landed as deb008d, 6737924 and 3ee6573

Please do send other pull requests! Sometimes it's hard to prevent duplication of effort.

@Narretz Narretz closed this Jun 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input["email"] and ngRequired are not working together anymore
6 participants