input["email"] and ngRequired are not working together anymore

[swisstofu]

input["email"] and ngRequired are not working together anymore

version : 1.3.0-beta.11
browsers: chrome, safari
OS: osx mavericks

hi guys, there is a regression in 1.3.x, that you can easily reproduce.

• go to page https://code.angularjs.org/1.3.0-beta.12/docs/api/ng/input/input%5Bemail%5D at the example in the bottom.
• clear the field (using select all, backspace)
• => now myForm.$error.required is true, which is correct
• type 'a'
• => myForm.$error.required is still true, and this is wrong

this used to work in stable version (https://code.angularjs.org/1.2.18/docs/api/ng/input/input%5Bemail%5D)

thanks

[caitp]

thanks for the bug report, I can confirm this. would you be interested in putting together a fix?

The behaviour should be somewhat similar to native constraint validation (http://jsfiddle.net/ep4Bf/)

[swisstofu]

yes, i will have a look

On Mon, Jun 16, 2014 at 5:02 PM, Caitlin Potter [email protected]
wrote:

thanks for the bug report, would you be interested in putting together a
fix?

—
Reply to this email directly or view it on GitHub
#7849 (comment).

[swisstofu]

i would propose the following in /Users/christophe.krebser/git/angular.js/src/ng/directive/input.js, row # 1138, replace function emailInputType with :

function emailInputType(scope, element, attr, ctrl, $sniffer, $browser) {
  textInputType(scope, element, attr, ctrl, $sniffer, $browser);

  var emailValidator = function(value) {
    return ctrl.$isEmpty(value) || EMAIL_REGEXP.test(value);
  };

  ctrl.$validators.email = emailValidator;
}

i tested it and it worked on my project. Other validators such as url and would need to be rewritten too. Do you want me to fork and pull request ?

[caitp]

Definitely. If you need help don't hesitate to ask =)

[swisstofu]

Ok thanks! well yes I would need some help, this is my first attempt to help so i'm a bit lost... i wrote a test case in test/ng/directive/inputSpec.js but I don't know how to execute it... grunt test just take ages on my side... is this something more specific to run only those tests ? thank you for your help

[Narretz]

@swisstofu Does the test suite finish at all? You can execute specific tests with changing it to iit or describe to ddescribe (But don'T forget to change it back)

[swisstofu]

@Narretz thanks for your answer. i was able to run test suite but i had to remove --head from 'version-info.js`, this doesn't seem to work on osx mavericks... don't know...

test suite wasn't completed because of other issues, but my test case works just fine so i would be ready to submit... i've created a branch but i'm not able to push it to angular repo (well that's sounds logical...).

@caitp how can I get the rights to do so ? or should I provide you with a fork ? i don't know the procedure sorry for that! thx for your help!

[Narretz]

@swisstofu You have to fork the angular.js repo on github. Then push your branch on the forked repo (remote) and initiate a pull request. Forking / creating a pull request is only possible from the github site / api, not from shell.

[swisstofu]

ok thanks @Narretz i've created the pull request here : #7868