This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngView): remove reference to scope #7583
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add two expect().toBe() lines to tests in ngClassDirective which lack them
Link "isolate scope" to "Directive Definition object" section Closes angular#7484
If you have two directives that both expect to receive transcluded content the outer directive works but the inner directive never receives a transclusion function. This only failed if the first transclude directive was not the first directive found in compilation. Fixes angular#7240 Closes angular#7387
Minor change puts \- at end of character pattern In CLASS_DIRECTIVE_REGEXP and COMMENT_DIRECTIVE_REGEXP, putting the \- character at the end of the character patter speeds up many IDE parsers and alleviates some errors in certain IDE's. (WebStorm 8) Functionally absolutely equivalent. No test change needed. Closes angular#7093 Conflicts: src/ng/compile.js
…as changed Calling `$commitViewValue` was was dirtying the input, even if no update to the view value was made. For example, `updateOn` triggers and form submit may call `$commitViewValue` even if the the view value had not changed. Closes angular#7457 Closes angular#7495
Muchas gracias! \o/ Closes angular#7507
The "Crawling your app" section was duplicated. I just removed the duplication and moved the section to the 'Caveats' section. Closes angular#7244
previously we stringified numbers via toJson which was expensive, I optimized the code so that toJson is invoked only if really necessary Closes angular#7501
Because of this[1] issue, which is Linux specific, we see very frequent failures. [1]: https://code.google.com/p/chromedriver/issues/detail?id=467
☆.。.：*・゜☆ DOMO ARIGATO MR ROBOTO ☆.。.：*・゜☆ Closes angular#7504
…rectives This reverts commit 1138506. This change introduced regressions for several scenarios. reduction: http://jsfiddle.net/5242N/4/
This CL enables interpolation expressions to be escaped, by prefixing each character of their
start/end markers with a REVERSE SOLIDUS U+005C, and to render the escaped expression as a
regular interpolation expression.
Example:
`<span ng-init="foo='Hello'">{{foo}}, \\{\\{World!\\}\\}</span>` would be rendered as:
`<span ng-init="foo='Hello'">Hello, {{World!}}</span>`
This will also work with custom interpolation markers, for example:
module.
config(function($interpolateProvider) {
$interpolateProvider.startSymbol('\\\\');
$interpolateProvider.endSymbol('//');
}).
run(function($interpolate) {
// Will alert with "hello\\bar//":
alert($interpolate('\\\\foo//\\\\\\\\bar\\/\\/')({foo: "hello", bar: "world"}));
});
This change effectively only changes the rendering of these escaped markers, because they are
not context-aware, and are incapable of preventing nested expressions within those escaped
markers from being evaluated.
Therefore, backends are encouraged to ensure that when escaping expressions for security
reasons, every single instance of a start or end marker have each of its characters prefixed
with a backslash (REVERSE SOLIDUS, U+005C)
Closes angular#5601
Closes angular#7517
I thought `jerk` illustrated the "defacing" factor nicely, but I suppose it's not very nice to have in official documentation.
Only use the apostrophe if you can expand "it's" to "it is" and still have a grammatical phrase. Closes angular#7524
When a event is finished propagating through Scope hierarchy the event's `currentScope` property should be reset to `null` to avoid accidental use of this property in asynchronous event handlers. In the previous code, the event's property would contain a reference to the last Scope instance that was visited during the traversal, which is unlikely what the code trying to grab scope reference expects. BREAKING CHANGE: $broadcast and $emit will now reset the `currentScope` property of the event to null once the event finished propagating. If any code depends on asynchronously accessing thei `currentScope` property, it should be migrated to use `targetScope` instead. All of these cases should be considered programming bugs. Closes angular#7445 Closes angular#7523
The ng-app was called ng=app in diagram image. Closes angular#6473 Closes angular#7528
ngRepeat no longer has the compile function in its directive definition object, since it retrieves its transclusion via the link function. Closes 5638
…tives If a directives specifies `replace:true` and the template of the directive contains a root element with an attribute which already exists at the place where the directive is used with the same value, don't duplicate the value. Closes angular#7463
BREAKING CHANGE: The `replace` flag for defining directives that replace the element that they are on will be removed in the next major angular version. This feature has difficult semantics (e.g. how attributes are merged) and leads to more problems compared to what it solves. Also, with WebComponents it is normal to have custom elements in the DOM.
replaced bootstrap 2 with bootstrap 3 classes Closes angular#7433
spaces between the ')' and '{' make code a tad easier to read.
Closes angular#7542
It was confusing to read "end 2 end" as a numeric two. I kept wondering what two end(s). Later in the tutorial, the text switched to "End to End" which made more sense than numeric two.
It's a feature that isn't exposed to the public, and is no longer used internally.
Previously, only files in test/ were checked. This does not capture end to end tests, which are in comments in src/.
Place phoneId binding in a proper HTML node
The code where the phoneId binding in the phone-detail.html template is first explained in step 7
of the tutorial doesn't make it a child of a proper HTML node, which makes the end-to-end test
against the view (also introduced in step 7) fail.
The test acquires the binding right from the view (by.binding('phoneId')), and apparently this
operation fails when the binding is not a child of an HTML node, and therefore the entire test also
fails. As soon as the binding is placed inside a <span></span> tag pair, the binding is found and
the test passes. The code on github for step 7 has it right, the binding is within the span tags,
but in the documentation I'm patching here the span's are missing.
☆.。.：*・゜☆ MERCI ☆.。.：*・゜☆
Closes angular#7561
The feature has been deprecated in angular#4317 BREAKING CHANGE: promise unwrapping has been removed. It has been deprecated since 1.2.0-rc.3. It can no longer be turned on. Two methods have been removed: * $parseProvider.unwrapPromises * $parseProvider.logPromiseWarnings
Expressions that start with `::` will be binded once. The rule
that binding follows is that the binding will take the first
not-undefined value at the end of a $digest cycle.
Watchers from $watch, $watchCollection and $watchGroup will
automatically stop watching when the expression(s) are bind-once
and fulfill.
Watchers from text and attributes interpolations will
automatically stop watching when the expressions are fulfill.
All directives that use $parse for expressions will automatically
work with bind-once expressions. E.g.
<div ng-bind="::foo"></div>
<li ng-repeat="item in ::items">{{::item.name}};</li>
Paired with: Caitlin and Igor
Design doc: https://docs.google.com/document/d/1fTqaaQYD2QE1rz-OywvRKFSpZirbWUPsnfaZaMq8fWI/edit#
Closes angular#7486
Closes angular#5408
Transitions that are run through ngAnimate which contain a specific property cause any inline styles to be erased after the animation is done. This has something to do with how the browsers handle transitions that do not use "all" as a transition property. Closes angular#7503
$route.name.scope.current returns undefined in the docs example, as scope is never injected into the relevant controller. Scope doesn't need to be there, so it's best to just remove it. Suggested in angular#5076
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
I have no idea why there are 76 commits in this PR. It looks like there was a bad merge, somewhere? All I did was fetch from upstream and merge into my master before working on this. |
|
Hey @RichardLitt! That's pretty crazy. Not sure what happened, but here's the recommended flow (from your working branch): git fetch upstream
git rebase upstream/masterI'm guessing you did |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$route.name.scope.current returns undefined in the docs example,
as scope is never injected into the relevant controller.
Scope doesn't need to be there, so it's best to just remove it.
Suggested in #5076.