This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngView): remove reference to scope #7584
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$route.name.scope.current returns undefined in the docs example, as scope is never injected into the relevant controller. Scope doesn't need to be there, so it's best to just remove it. Suggested in angular#5076.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
Let's pretend #7583 never happened. Fixed tree. Better. |
|
You can actually update existing PRs by force-pushing to the same remote branch. |
|
By the time I fixed my local git, seemed easier to just delete and redo the changes in a new branch. It's only one line of code. :P You're right, though. Will do that if I merge by accident in the future. |
|
Landed as 3fc95e0. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$route.name.scope.current returns undefined in the docs example,
as scope is never injected into the relevant controller.
Scope doesn't need to be there, so it's best to just remove it.
Suggested in #5076.