This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(ngRoute): ngRoute does not parseInt possible integer route parts in $routeParams #7386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
caitp
changed the title
|
Hi, could you fix the commit message please? Just so that nobody forgets to amend it. It's a docs fix, not a bugfix. |
|
Updated, I think! |
wesalvaro
changed the title
wesalvaro
changed the title
wesalvaro
changed the title
petebacondarwin
pushed a commit
that referenced
this pull request
May 21, 2014
RichardLitt
pushed a commit
to RichardLitt/angular.js
that referenced
this pull request
May 24, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request Type: docs
How to reproduce: View docs for $routeParams
Component(s): ngRoute
Impact: small
Complexity: small
Detailed Description:
Bad documented type for $routeParams. It should be an Object.<string, string>
Integers are not parsed for the user. They must be parsed from the string pulled from the URL.