This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(guide/displaying-data): proofread #1819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Foxandxss @wardbell @kwalrath : ready for review. As usual, it is best viewed by ignoring whitespace diffs. |
|
TS part works for me. |
chalin
force-pushed
the
chalin-guide-disp-data-0702
branch
from
d653f20 to
13e7e07
Compare
| * declares a constructor parameter and its type | ||
| * declares a public property of the same name | ||
| * initializes that property with the corresponding argument when we "new" an instance of the class | ||
| +makeExcerpt('app/hero.ts ()', 'id') |
There was a problem hiding this comment.
Because of the () the mixin will render the title as app/hero.ts (excerpt).
chalin
force-pushed
the
chalin-guide-disp-data-0702
branch
from
13e7e07 to
db70c41
Compare
| * [Conditional display with NgIf](#ngIf) | ||
|
|
||
| <li if-docs="ts">only ts</li> |
There was a problem hiding this comment.
Why is this line here? This shows up as a weird "only ts" bullet item in the TS version of the docs...
There was a problem hiding this comment.
That was just for a test. It should not have been left in (no sure how it slipped by). Thanks for catching it!
Fixed.
|
I did a side-by-side comparison, and apart from the couple of minor things I commented on, LGTM. |
chalin
force-pushed
the
chalin-guide-disp-data-0702
branch
from
db70c41 to
13fe33f
Compare
|
Fixed and committed. |
- Dart prose simplified by removing discussion of "additions to pubspec.yaml" which are no longer necessary given the current state of QuickStart. - E2e suites passed: public/docs/_examples/displaying-data/dart public/docs/_examples/displaying-data/ts Contributes to angular#1598 and angular#1508.
- TS prose updated to include @kwalrath's revisions from a while ago, with some of my edits as well. - E2e suites passed: public/docs/_examples/displaying-data/dart public/docs/_examples/displaying-data/ts
chalin
force-pushed
the
chalin-guide-disp-data-0702
branch
from
13fe33f to
1fb1df4
Compare
|
LGTM |
This was referenced Jul 7, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pubspec.yaml" which are no longer necessary given the current state of QuickStart.Contributes to #1598 and #1508.
Depends on #1818.