Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Update Basics to new design scheme using Jade extends/blocks #1508

Closed
6 of 7 tasks
chalin opened this issue May 25, 2016 · 3 comments
Closed
6 of 7 tasks

Update Basics to new design scheme using Jade extends/blocks #1508

chalin opened this issue May 25, 2016 · 3 comments
Labels
dart

Comments

@chalin
Copy link
Contributor

chalin commented May 25, 2016 •
edited
Loading

Contributes to #1506.
@chalin chalin mentioned this issue May 25, 2016
Closed
4 tasks
@chalin chalin changed the title basic dev guide: use new doc design scheme using Jade extends/blocks basic dev guide: use new design scheme using Jade extends/blocks May 25, 2016
This was referenced May 25, 2016
Closed
Merged
@chalin chalin changed the title basic dev guide: use new design scheme using Jade extends/blocks Update Basics to new design scheme using Jade extends/blocks May 25, 2016
@wardbell
Copy link
Contributor

Please hold on this project!

@chalin
Copy link
Contributor Author

chalin commented May 29, 2016

Please hold on this project!

Ok. FYI, I am almost done (95%) with the dependency-injection chapter. I'll commit on Tuesday. Will hold off working on the other chapters until I hear news from you.

cc: @kwalrath

chalin added a commit to chalin/angular.io that referenced this issue Jun 1, 2016
@chalin
docs(dependency-injection): revised Dart and TS code and prose
85bc650 
Contributes to angular#1508 and angular#1522.

- The main change on the TS side is to present best practices first, rather than presenting sample code and then saying "don't do that".
- The "Optional dependencies" section has been moved towards the end of the provider variants section and its sample code has been simplified.
- Reworked *_1.{ts,dart} sources so that main_1.{ts,dart} can actually be run, which helped find some bugs in those sources.
- Despite angular/angular#8928, the Dart and TS OpaqueToken sections have been left in the prose. They can be revisited later.

Enhancements to the Dart code include:

- Added TestComponent.
- Added a provider sample that makes use of an app config Map (to match TS); also added the more Dart-like use of a custom app configuration class, whose instance is initialized via the cascade operator.
- Fixed Engine class hierarchy so that a single field named `cylinders` is defined (rather than two fields: one in the Engine supertype and one in the subclass), because having two fields is a bad design smell.
- Similarly, fixed Logger hierarchy so that a single field named `logs` is defined. Also made `logs` a read-only field.
- Reintroduced the SilentLogger().
@chalin chalin mentioned this issue Jun 1, 2016
Merged
chalin added a commit to chalin/angular.io that referenced this issue Jun 1, 2016
@chalin
docs(dependency-injection): revised Dart and TS code and prose
324ec98 
Contributes to angular#1508 and angular#1522.

- The main change on the TS side is to present best practices first, rather than presenting sample code and then saying "don't do that".
- The "Optional dependencies" section has been moved towards the end of the provider variants section and its sample code has been simplified.
- Reworked *_1.{ts,dart} sources so that main_1.{ts,dart} can actually be run, which helped find some bugs in those sources.
- Despite angular/angular#8928, the Dart and TS OpaqueToken sections have been left in the prose. They can be revisited later.

Enhancements to the Dart code include:

- Added TestComponent.
- Added a provider sample that makes use of an app config Map (to match TS); also added the more Dart-like use of a custom app configuration class, whose instance is initialized via the cascade operator.
- Fixed Engine class hierarchy so that a single field named `cylinders` is defined (rather than two fields: one in the Engine supertype and one in the subclass), because having two fields is a bad design smell.
- Similarly, fixed Logger hierarchy so that a single field named `logs` is defined. Also made `logs` a read-only field.
- Reintroduced the SilentLogger().
chalin added a commit to chalin/angular.io that referenced this issue Jun 2, 2016
@chalin
docs(dependency-injection): revised Dart and TS code and prose
f2a5e83 
Contributes to angular#1508 and angular#1522.

- The main change on the TS side is to present best practices first, rather than presenting sample code and then saying "don't do that".
- The "Optional dependencies" section has been moved towards the end of the provider variants section and its sample code has been simplified.
- Reworked *_1.{ts,dart} sources so that main_1.{ts,dart} can actually be run, which helped find some bugs in those sources.
- Despite angular/angular#8928, the Dart and TS OpaqueToken sections have been left in the prose. They can be revisited later.

Enhancements to the Dart code include:

- Added TestComponent.
- Added a provider sample that makes use of an app config Map (to match TS); also added the more Dart-like use of a custom app configuration class, whose instance is initialized via the cascade operator.
- Fixed Engine class hierarchy so that a single field named `cylinders` is defined (rather than two fields: one in the Engine supertype and one in the subclass), because having two fields is a bad design smell.
- Similarly, fixed Logger hierarchy so that a single field named `logs` is defined. Also made `logs` a read-only field.
- Reintroduced the SilentLogger().
@kwalrath kwalrath added the dart label Jun 3, 2016
chalin added a commit to chalin/angular.io that referenced this issue Jun 3, 2016
@chalin
docs(dependency-injection): revised Dart and TS code and prose
c489b17 
Contributes to angular#1508 and angular#1522.

- The main change on the TS side is to present best practices first, rather than presenting sample code and then saying "don't do that".
- The "Optional dependencies" section has been moved towards the end of the provider variants section and its sample code has been simplified.
- Reworked *_1.{ts,dart} sources so that main_1.{ts,dart} can actually be run, which helped find some bugs in those sources.
- Despite angular/angular#8928, the Dart and TS OpaqueToken sections have been left in the prose. They can be revisited later.

Enhancements to the Dart code include:

- Added TestComponent.
- Added a provider sample that makes use of an app config Map (to match TS); also added the more Dart-like use of a custom app configuration class, whose instance is initialized via the cascade operator.
- Fixed Engine class hierarchy so that a single field named `cylinders` is defined (rather than two fields: one in the Engine supertype and one in the subclass), because having two fields is a bad design smell.
- Similarly, fixed Logger hierarchy so that a single field named `logs` is defined. Also made `logs` a read-only field.
- Reintroduced the SilentLogger().
chalin added a commit to chalin/angular.io that referenced this issue Jun 3, 2016
@chalin
docs(dependency-injection): revised Dart and TS code and prose
f9dac13 
Contributes to angular#1508 and angular#1522.

- The main change on the TS side is to present best practices first, rather than presenting sample code and then saying "don't do that".
- The "Optional dependencies" section has been moved towards the end of the provider variants section and its sample code has been simplified.
- Reworked *_1.{ts,dart} sources so that main_1.{ts,dart} can actually be run, which helped find some bugs in those sources.
- Despite angular/angular#8928, the Dart and TS OpaqueToken sections have been left in the prose. They can be revisited later.

Enhancements to the Dart code include:

- Added TestComponent.
- Added a provider sample that makes use of an app config Map (to match TS); also added the more Dart-like use of a custom app configuration class, whose instance is initialized via the cascade operator.
- Fixed Engine class hierarchy so that a single field named `cylinders` is defined (rather than two fields: one in the Engine supertype and one in the subclass), because having two fields is a bad design smell.
- Similarly, fixed Logger hierarchy so that a single field named `logs` is defined. Also made `logs` a read-only field.
- Reintroduced the SilentLogger().
@chalin chalin mentioned this issue Jun 3, 2016
Closed
7 tasks
chalin added a commit to chalin/angular.io that referenced this issue Jul 1, 2016
@chalin
docs(architecture/dart): proofread, updated Dart app
3855d75 
- e2e tests now also cover the tax calculator.
- Dart app updated to match TS (it had no sales tax calculator).
- TS sample source cleanup (e.g. removed many unnecessary `docregions`).
- Prose updated to include @kwalrath's revisions from a while ago, with
some of my edits as well.

Contributes to angular#1598 and angular#1508.
chalin added a commit to chalin/angular.io that referenced this issue Jul 1, 2016
@chalin
docs(architecture/ts): proofread
5488fec 
- e2e tests now also cover the tax calculator.
- Dart app updated to match TS (it had no sales tax calculator).
- TS sample source cleanup (e.g. removed many unnecessary `docregions`).
- Prose updated to include @kwalrath's revisions from a while ago, with
some of my edits as well.

Contributes to angular#1598 and angular#1508.
@chalin chalin mentioned this issue Jul 1, 2016
Closed
chalin added a commit to chalin/angular.io that referenced this issue Jul 1, 2016
@chalin
docs(architecture/dart): proofread, updated Dart app
a0af226 
- e2e tests now also cover the tax calculator.
- Dart app updated to match TS (it had no sales tax calculator).
- TS sample source cleanup (e.g. removed many unnecessary `docregions`).
- Prose updated to include @kwalrath's revisions from a while ago, with
some of my edits as well.

Contributes to angular#1598 and angular#1508.
chalin added a commit to chalin/angular.io that referenced this issue Jul 1, 2016
@chalin
docs(architecture/ts): proofread
735fd90 
- e2e tests now also cover the tax calculator.
- Dart app updated to match TS (it had no sales tax calculator).
- TS sample source cleanup (e.g. removed many unnecessary `docregions`).
- Prose updated to include @kwalrath's revisions from a while ago, with
some of my edits as well.

Contributes to angular#1598 and angular#1508.
chalin added a commit to chalin/angular.io that referenced this issue Jul 1, 2016
@chalin
docs(architecture/dart): proofread, updated Dart app
a406ea1 
- e2e tests now also cover the tax calculator.
- Dart app updated to match TS (it had no sales tax calculator).
- TS sample source cleanup (e.g. removed many unnecessary `docregions`).
- Prose updated to include @kwalrath's revisions from a while ago, with
some of my edits as well.

Contributes to angular#1598 and angular#1508.
chalin added a commit to chalin/angular.io that referenced this issue Jul 1, 2016
@chalin
docs(architecture/ts): proofread
637d382 
- e2e tests now also cover the tax calculator.
- Dart app updated to match TS (it had no sales tax calculator).
- TS sample source cleanup (e.g. removed many unnecessary `docregions`).
- Prose updated to include @kwalrath's revisions from a while ago, with
some of my edits as well.

Contributes to angular#1598 and angular#1508.
chalin added a commit to chalin/angular.io that referenced this issue Jul 2, 2016
@chalin
docs(architecture/dart): proofread, updated Dart app
21d8302 
- e2e tests now also cover the tax calculator.
- Dart app updated to match TS (it had no sales tax calculator).
- TS sample source cleanup (e.g. removed many unnecessary `docregions`).
- Prose updated to include @kwalrath's revisions from a while ago, with
some of my edits as well.

Contributes to angular#1598 and angular#1508.
chalin added a commit to chalin/angular.io that referenced this issue Jul 2, 2016
@chalin
docs(architecture/ts): proofread
479ef5b 
- e2e tests now also cover the tax calculator.
- Dart app updated to match TS (it had no sales tax calculator).
- TS sample source cleanup (e.g. removed many unnecessary `docregions`).
- Prose updated to include @kwalrath's revisions from a while ago, with
some of my edits as well.

Contributes to angular#1598 and angular#1508.
chalin added a commit to chalin/angular.io that referenced this issue Jul 3, 2016
@chalin
docs(architecture/dart): proofread, updated Dart app
73f056c 
- e2e tests now also cover the tax calculator.
- Dart app updated to match TS (it had no sales tax calculator).
- TS sample source cleanup (e.g. removed many unnecessary `docregions`).
- Prose updated to include @kwalrath's revisions from a while ago, with
some of my edits as well.

Contributes to angular#1598 and angular#1508.
chalin added a commit to chalin/angular.io that referenced this issue Jul 3, 2016
@chalin
docs(architecture/ts): proofread
258c81a 
- e2e tests now also cover the tax calculator.
- Dart app updated to match TS (it had no sales tax calculator).
- TS sample source cleanup (e.g. removed many unnecessary `docregions`).
- Prose updated to include @kwalrath's revisions from a while ago, with
some of my edits as well.

Contributes to angular#1598 and angular#1508.
chalin added a commit to chalin/angular.io that referenced this issue Jul 4, 2016
@chalin
docs(displaying-data/dart): proofread
adf80d8 
- Dart prose simplified by removing discussion of "additions to
pubspec.yaml" which are no longer necessary given the current state of
QuickStart.
- E2e suites passed:
  public/docs/_examples/displaying-data/dart
  public/docs/_examples/displaying-data/ts

Contributes to angular#1598 and angular#1508.
@chalin chalin mentioned this issue Jul 4, 2016
Merged
chalin added a commit to chalin/angular.io that referenced this issue Jul 4, 2016
@chalin
docs(architecture/dart): proofread, updated Dart app
037be4e 
- e2e tests now also cover the tax calculator.
- Dart app updated to match TS (it had no sales tax calculator).
- TS sample source cleanup (e.g. removed many unnecessary `docregions`).
- Prose updated to include @kwalrath's revisions from a while ago, with
some of my edits as well.

Contributes to angular#1598 and angular#1508.
chalin added a commit to chalin/angular.io that referenced this issue Jul 4, 2016
@chalin
docs(architecture/ts): proofread
d972d5a 
- e2e tests now also cover the tax calculator.
- Dart app updated to match TS (it had no sales tax calculator).
- TS sample source cleanup (e.g. removed many unnecessary `docregions`).
- Prose updated to include @kwalrath's revisions from a while ago, with
some of my edits as well.

Contributes to angular#1598 and angular#1508.
chalin added a commit to chalin/angular.io that referenced this issue Jul 4, 2016
@chalin
docs(displaying-data/dart): proofread
51bfcf9 
- Dart prose simplified by removing discussion of "additions to
pubspec.yaml" which are no longer necessary given the current state of
QuickStart.
- E2e suites passed:
  public/docs/_examples/displaying-data/dart
  public/docs/_examples/displaying-data/ts

Contributes to angular#1598 and angular#1508.
chalin added a commit to chalin/angular.io that referenced this issue Jul 6, 2016
@chalin
docs(architecture/dart): proofread, updated Dart app
933ebc4 
- e2e tests now also cover the tax calculator.
- Dart app updated to match TS (it had no sales tax calculator).
- TS sample source cleanup (e.g. removed many unnecessary `docregions`).
- Prose updated to include @kwalrath's revisions from a while ago, with
some of my edits as well.

Contributes to angular#1598 and angular#1508.
chalin added a commit to chalin/angular.io that referenced this issue Jul 6, 2016
@chalin
docs(architecture/ts): proofread
bcb7e95 
- e2e tests now also cover the tax calculator.
- Dart app updated to match TS (it had no sales tax calculator).
- TS sample source cleanup (e.g. removed many unnecessary `docregions`).
- Prose updated to include @kwalrath's revisions from a while ago, with
some of my edits as well.

Contributes to angular#1598 and angular#1508.
chalin added a commit to chalin/angular.io that referenced this issue Jul 6, 2016
@chalin
docs(displaying-data/dart): proofread
ec3d91f 
- Dart prose simplified by removing discussion of "additions to
pubspec.yaml" which are no longer necessary given the current state of
QuickStart.
- E2e suites passed:
  public/docs/_examples/displaying-data/dart
  public/docs/_examples/displaying-data/ts

Contributes to angular#1598 and angular#1508.
chalin added a commit to chalin/angular.io that referenced this issue Jul 7, 2016
@chalin
docs(displaying-data/dart): proofread
4f1a68b 
- Dart prose simplified by removing discussion of "additions to
pubspec.yaml" which are no longer necessary given the current state of
QuickStart.
- E2e suites passed:
  public/docs/_examples/displaying-data/dart
  public/docs/_examples/displaying-data/ts

Contributes to angular#1598 and angular#1508.
chalin added a commit to chalin/angular.io that referenced this issue Jul 7, 2016
@chalin
docs(displaying-data/dart): proofread
2e83989 
- Dart prose simplified by removing discussion of "additions to
pubspec.yaml" which are no longer necessary given the current state of
QuickStart.
- E2e suites passed:
  public/docs/_examples/displaying-data/dart
  public/docs/_examples/displaying-data/ts

Contributes to angular#1598 and angular#1508.
kwalrath pushed a commit that referenced this issue Jul 7, 2016
@chalin @kwalrath
docs(guide/displaying-data): proofread (#1819)
801ac76 
* docs(displaying-data/dart): proofread

- Dart prose simplified by removing discussion of "additions to
pubspec.yaml" which are no longer necessary given the current state of
QuickStart.
- E2e suites passed:
  public/docs/_examples/displaying-data/dart
  public/docs/_examples/displaying-data/ts

Contributes to #1598 and #1508.

* docs(displaying-data/ts): proofread

- TS prose updated to include @kwalrath's revisions from a while ago,
with some of my edits as well.
- E2e suites passed:
  public/docs/_examples/displaying-data/dart
  public/docs/_examples/displaying-data/ts

* docs(displaying-data/ts): post-review edits
chalin added a commit to chalin/angular.io that referenced this issue Jul 8, 2016
@chalin
docs(architecture/dart): proofread, updated Dart app
d77a636 
- e2e tests now also cover the tax calculator.
- Dart app updated to match TS (it had no sales tax calculator).
- TS sample source cleanup (e.g. removed many unnecessary `docregions`).
- Prose updated to include @kwalrath's revisions from a while ago, with
some of my edits as well.

Contributes to angular#1598 and angular#1508.
chalin added a commit to chalin/angular.io that referenced this issue Jul 8, 2016
@chalin
docs(architecture/ts): proofread
c73052a 
- e2e tests now also cover the tax calculator.
- Dart app updated to match TS (it had no sales tax calculator).
- TS sample source cleanup (e.g. removed many unnecessary `docregions`).
- Prose updated to include @kwalrath's revisions from a while ago, with
some of my edits as well.

Contributes to angular#1598 and angular#1508.
wardbell pushed a commit that referenced this issue Jul 12, 2016
@chalin @wardbell
docs(architecture/dart): proofread, updated Dart/TS app and jade
761f857 
closes #1807
- e2e tests now also cover the tax calculator.
- Dart app updated to match TS (it had no sales tax calculator).
- TS sample source cleanup (e.g. removed many unnecessary `docregions`).
- Prose updated to include @kwalrath's revisions from a while ago, Ward's comments, and
some of my edits as well.

Contributes to #1598 and #1508.
@chalin chalin mentioned this issue Aug 13, 2016
Merged
@chalin
Copy link
Contributor Author

chalin commented Dec 16, 2016

We will no longer be implementing this new scheme.

@chalin chalin closed this as completed Dec 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
dart
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wardbell @kwalrath @chalin